Feed Advanced Search

Aug 22 2016

nicholasl added a comment to D2527: Disable multithreading in threshold filter.

Ah, I see. In toQColor, you added the lock inside the "else" clause of an if statement. If I set a breakpoint, I end up inside the "profile == 0" part.
I can no longer reproduce the issue after moving the lock to the first line of the function.

Aug 22 2016, 9:45 PM
nicholasl added a comment to D2527: Disable multithreading in threshold filter.

I'm glad to hear that a problem was fixed! Unfortunately, I pulled the changes and I'm still able to reproduce both the rectangles and the incorrect single pixels. Did your commits fix it for you?

Aug 22 2016, 5:10 PM
nicholasl added a comment to D2527: Disable multithreading in threshold filter.

Not sure about the addition of 0.5, but your mention of intensity8 made me try something else. I wonder if this is the issue?
(I'm compiling with "CMAKE_BUILD_TYPE=Debug" to prevent unused variables from being optimized out.)

Aug 22 2016, 4:01 PM
nicholasl retitled D2527: Disable multithreading in threshold filter from to Disable multithreading in threshold filter.
Aug 22 2016, 10:45 AM

Feb 9 2016

nicholasl closed D849: Limit lowest selectable animation frame rate to 1FPS.

A commit which included an identical change was made on the 2nd (rKRITAfa2b0d77fe9e1e6b0675a3ab83d00c272cb37c2d), so I'm going to close this revision.

Feb 9 2016, 9:50 AM

Jan 22 2016

nicholasl added a comment to D849: Limit lowest selectable animation frame rate to 1FPS.

I don't have the repository rights to push it myself.

Jan 22 2016, 10:26 AM

Jan 21 2016

nicholasl closed D548: Krita - Make some file formats return KisImportExportFilter::UserCancelled when their options dialogs are cancelled.
Jan 21 2016, 3:34 PM
nicholasl retitled D849: Limit lowest selectable animation frame rate to 1FPS from to Limit lowest selectable animation frame rate to 1FPS.
Jan 21 2016, 3:33 PM

Nov 16 2015

nicholasl added a comment to D548: Krita - Make some file formats return KisImportExportFilter::UserCancelled when their options dialogs are cancelled.

I'm unable to push since I don't have developer access.

Nov 16 2015, 6:26 PM
nicholasl retitled D548: Krita - Make some file formats return KisImportExportFilter::UserCancelled when their options dialogs are cancelled from to Krita - Make some file formats return KisImportExportFilter::UserCancelled when their options dialogs are cancelled.
Nov 16 2015, 2:15 AM