Differential D3477

Miscellaneous helper cleanups
ClosedPublic
Actions

Authored by flherne on Nov 23 2016, 4:32 PM.

Details

Reviewers
brauch
Summary
  • Simplify some code that was mainly duplicating accessAttribute().
  • Improve accessAttribute() with ideas from the removed copies.
    • Yes, I changed the method signature twice in three patches...
  • Replace QList with QVector in internalContextsForClass(), make type ptr const.
  • Remove unused return in getDocumentationFileContext().
  • Remove unused -typedef QPair<Declaration*, int> p; in declarationbuilder.cpp.
Test Plan

No test changes/regressions.

No intended changes in behaviour.

Diff Detail

Repository
R53 KDevelop: Python Support
Lint
Lint Skipped
Unit
Unit Tests Skipped
flherne updated this revision to Diff 8455.Nov 23 2016, 4:32 PM
flherne retitled this revision from to Miscellaneous helper cleanups.
flherne updated this object.
flherne edited the test plan for this revision. (Show Details)
flherne added a reviewer: brauch.
flherne set the repository for this revision to R53 KDevelop: Python Support.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptNov 23 2016, 4:32 PM
brauch accepted this revision.EditedNov 24 2016, 7:17 PM
brauch edited edge metadata.

Looks good, thanks.

duchain/expressionvisitor.cpp
386

bad variable name

387

if we're cleaning up already, make this an auto too.

duchain/helpers.cpp
230

auto here too if you touch this anyways

This revision is now accepted and ready to land.Nov 24 2016, 7:17 PM
flherne closed this revision.Nov 25 2016, 12:14 AM

Committed.

Revision Contents
Changeset List

Diff 8455

View Options

codecompletion/context.cpp

Loading...
View Options

duchain/declarationbuilder.cpp

Loading...
View Options

duchain/expressionvisitor.cpp

Loading...
View Options

duchain/helpers.h

Loading...
View Options

duchain/helpers.cpp

Loading...