Minor, non intrusive change
Details
Diff Detail
- Repository
- R14 KReport
- Branch
- dptr_kreportpageoptions
- Lint
No Linters Available - Unit
No Unit Test Coverage
src/common/KReportPageOptions.h | ||
---|---|---|
0 | Can't we go for QPageLayout? |
src/common/KReportPageOptions.h | ||
---|---|---|
0 | BTW KReportDesign already uses it. |
Nice!
src/common/KReportDocument.cpp | ||
---|---|---|
57 | Will be moved later to dptr, right? | |
118–125 | --8X-- | |
src/common/KReportDocument.h | ||
98 | +const | |
98 | If it's unused shouldn't we add #if 0 around this getter and setter? We don't know exact API we'll need for label types... | |
src/wrtembed/KReportDesigner.cpp | ||
868–871 | Better no abbreviations like this... |
Build and run the test app and Kexi.
Only for the map element: ASSERT: "m_topLevel <= m_bottomLevel" in file src/marble/src/lib/marble/TileCoordsPyramid.cpp, line 37
No idea if that's related, not tried maps for a while.
src/common/KReportDocument.cpp | ||
---|---|---|
57 | Ok, i'll do that in a separate commit | |
src/common/KReportDocument.h | ||
98 | i agree, however, the parser has always supported loading the label info from the XML, we just dont expose it, so I think we need somewhere to load to, even though we dont expose it yet. The loading code is ported from the original OpenRPT, and the label definitions are also from there. What do u think? |
Thanks, almost there!
src/common/KReportDocument.cpp | ||
---|---|---|
100 | --8x-- | |
src/common/KReportDocument.h | ||
19 | While we're at it: -> KREPORTDOCUMENT_H | |
98 | I see KReportPreRendererPrivate::generateDocument() uses labelType(). Because KReportPreRendererPrivate is a friend of KReportDocument, would it be possible to make labelType/setLabelType private for now? |
1 line to remove and OK!
src/common/KReportDocument.cpp | ||
---|---|---|
118–125 | please remove the !Page Layout==== |