Differential D28536

libs/qtav: fixed windows build
ClosedPublic
Actions

Authored by maxrd2 on Apr 3 2020, 1:20 PM.

Details

Reviewers
vonreth
Group Reviewers
Craft
Commits
R877:52007295b9f8: libs/qtav: fixed windows build
Summary

Windows build could not find ffmpeg dependencies

Diff Detail

Repository
R877 Craft Blueprints for KDE
Branch
qtav
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24715
Build 24733: arc lint + arc unit
maxrd2 requested review of this revision.Apr 3 2020, 1:20 PM
maxrd2 created this revision.
maxrd2 added inline comments.Apr 3 2020, 1:26 PM
libs/qtav/qtav.py
40

For some reason libs/ffmpeg on windows is installing .lib files under bin/ ... that doesn't look right.. does it?

maxrd2 updated this revision to Diff 79215.Apr 3 2020, 1:37 PM

libs/qtav: fixed build

Summary: Build could not find ffmpeg dependencies

Reviewers: Craft, vonreth

Differential Revision: https://phabricator.kde.org/D28536

vonreth added a comment.Apr 3 2020, 1:40 PM

Hm yes sounds like we should fix our ffmpeg blueprint with a post install step.

vonreth added a comment.Apr 3 2020, 1:42 PM

And for the include path, could we patch the qmake project file.

maxrd2 added a comment.Apr 3 2020, 5:21 PM
In D28536#640738, @vonreth wrote:

Hm yes sounds like we should fix our ffmpeg blueprint with a post install step.

Created patch here: https://phabricator.kde.org/D28543

In D28536#640739, @vonreth wrote:

And for the include path, could we patch the qmake project file.

Sure, but how do I place craftRoot into a .qmake file?
BTW those steps I've added to .qmake.conf file are what I've read on official build steps here: https://github.com/wang-bin/QtAV/wiki/Build-QtAV#recommended-edit-qmakeconf-if-use-qmake

maxrd2 updated this revision to Diff 79239.Apr 3 2020, 5:25 PM

Removed bin/ lib path on windows

vonreth added a comment.Apr 3 2020, 7:01 PM
In D28536#640890, @maxrd2 wrote:
In D28536#640738, @vonreth wrote:

Hm yes sounds like we should fix our ffmpeg blueprint with a post install step.

Created patch here: https://phabricator.kde.org/D28543

In D28536#640739, @vonreth wrote:

And for the include path, could we patch the qmake project file.

Sure, but how do I place craftRoot into a .qmake file?
BTW those steps I've added to .qmake.conf file are what I've read on official build steps here: https://github.com/wang-bin/QtAV/wiki/Build-QtAV#recommended-edit-qmakeconf-if-use-qmake

Hmmm qt install path something foo?

maxrd2 updated this revision to Diff 79249.Apr 3 2020, 8:01 PM

Moved include/lib search paths to qmake config patch

maxrd2 marked an inline comment as done.Apr 3 2020, 8:02 PM
vonreth accepted this revision.Apr 3 2020, 8:42 PM
This revision is now accepted and ready to land.Apr 3 2020, 8:42 PM
maxrd2 updated this revision to Diff 79280.Apr 4 2020, 11:39 AM
  • libs/qtav: fixed windows install
vonreth accepted this revision.Apr 4 2020, 2:05 PM
Closed by commit R877:52007295b9f8: libs/qtav: fixed windows build (authored by maxrd2). · Explain WhyApr 4 2020, 8:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 79280

View Options

libs/qtav/0003-Add-craft-search-paths.patch

Loading...
View Options

libs/qtav/qtav.py

Loading...