No need to keep them around for no reason.
Details
- Reviewers
zzag - Group Reviewers
KWin - Commits
- R108:cca0e15b455b: Fix compiler warnings
Tested the plugins I thought could be affected. Have been using it for a couple of days without problems
Diff Detail
- Repository
- R108 KWin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
debug_console.cpp | ||
---|---|---|
713 | According to Qt documentation, we should interpret QVariant::Type as QMetaType::Type.
| |
effects/screenshot/screenshot.cpp | ||
661 | Do compilers bark about using c-style casts? | |
main_wayland.cpp | ||
264 | Indentation is off. | |
plugins/kdecorations/aurorae/src/aurorae.cpp | ||
599 | Unrelated side note: this is really wrong! | |
wayland_server.cpp | ||
734 | Unrelated side note: I don't get why Qt folks deprecated toSet(). Range-based initialization looks very clunky if you ask me. |
effects/screenshot/screenshot.cpp | ||
---|---|---|
661 | The warning is: |
wayland_server.cpp | ||
---|---|---|
734 | I don't get it either. |
debug_console.cpp | ||
---|---|---|
713 | Could you please revert this change? The documentation says that we should use QMetaType. I assume the compiler doesn't like conversions between QVariant::Type and QMetaType::Type. If that's the case, we could cast the return value of value.type() or use value.userType() as Qt folks do. |
debug_console.cpp | ||
---|---|---|
713 | It doesn't make much sense since QVartiant's are defined in terms of QMetaType: SizeF = QMetaType::QSizeF. But sure, changing for your peace of mind. |
main_wayland.cpp | ||
---|---|---|
262–264 | void start(const QString &command, OpenMode mode = ReadWrite); is deprecated. We could also use |
main_wayland.cpp | ||
---|---|---|
262–264 | Is it deprecated in Qt 5.15? |
Hmm, it looks like CI still uses Qt 5.12. :(
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/620/console
This change broke launching applications with arguments, e.g. dbus-run-session kwin_wayland --width 1920 --height 1080 --xwayland "kate file.txt"