Differential D329

Port to KDevelop::Stack
ClosedPublic
Actions

Authored by kfunk on Sep 6 2015, 4:58 PM.

Tags

Subscribers

mwolff, kdevelop-devel

Details

Reviewers

Group Reviewers

Commits

R32:2067f9739ce4: Port to KDevelop::Stack

Diff Detail

Repository

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

kfunk updated this revision to Diff 766.Sep 6 2015, 4:58 PM

kfunk retitled this revision from to Port to KDevelop::Stack.

kfunk updated this object.

kfunk edited the test plan for this revision. (Show Details)

Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptSep 6 2015, 4:58 PM

kfunk added a reviewer: KDevelop.Sep 6 2015, 4:58 PM

kfunk added a project: KDevelop.

in general +1, nice!

languages/qmljs/codecompletion/context.cpp
250	bind to const& to prevent copying
languages/qmljs/duchain/expressionvisitor.h
22	unused, remove
projectmanagers/cmake/duchain/usebuilder.h
24	unused, remove
projectmanagers/cmake/parser/cmakelistsparser.cpp
27	unused, remove

This patch is on hold as I've started to see random crashes in kdev-clang during parsing; I'll first check if it's related to this patch.

if you figure out the issue is related to this patch then fix it, otherwise +1 :)

This revision is now accepted and ready to land.Oct 8 2015, 10:09 AM

Closed by commit R32:2067f9739ce4: Port to KDevelop::Stack (authored by kfunk). · Explain WhyNov 29 2015, 2:23 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			languages/cpp/cppduchain/contextbuilder.h (2 lines)
M			languages/cpp/cppduchain/cppducontext.h (3 lines)
M			languages/cpp/cppduchain/declarationbuilder.h (14 lines)
M			languages/cpp/cppduchain/typebuilder.h (2 lines)
M			languages/cpp/cppduchain/usebuilder.h (6 lines)
M			languages/cpp/cppduchain/usedecoratorvisitor.h (6 lines)
M			languages/cpp/parser/rpp/pp-engine.h (4 lines)
M			languages/cpp/parser/rpp/pp-environment.h (2 lines)
M			languages/qmljs/codecompletion/context.h (2 lines)
M			languages/qmljs/codecompletion/context.cpp (6 lines)
M			languages/qmljs/duchain/declarationbuilder.h (4 lines)
M			languages/qmljs/duchain/expressionvisitor.h (2 lines)
M			languages/qmljs/duchain/usebuilder.h (4 lines)
M			projectmanagers/cmake/duchain/usebuilder.h (2 lines)
M			projectmanagers/cmake/parser/cmakelistsparser.cpp (2 lines)
M			projectmanagers/cmake/parser/cmakeprojectvisitor.h (6 lines)
M			projectmanagers/cmake/parser/cmakeprojectvisitor.cpp (6 lines)
M			projectmanagers/cmake/parser/variablemap.h (4 lines)
M			projectmanagers/qmake/parser/CMakeLists.txt (5 lines)
M			projectmanagers/qmake/parser/buildastvisitor.h (4 lines)
M			projectmanagers/qmake/parser/qmakelexer.h (4 lines)
M			projectmanagers/qmake/qmakefile.h (2 lines)
M			providers/kdeprovider/kdeprojectsreader.h (7 lines)

Diff 766

languages/cpp/cppduchain/contextbuilder.h

Loading...

languages/cpp/cppduchain/cppducontext.h

Loading...

languages/cpp/cppduchain/declarationbuilder.h

Loading...

languages/cpp/cppduchain/typebuilder.h

Loading...

languages/cpp/cppduchain/usebuilder.h

Loading...

languages/cpp/cppduchain/usedecoratorvisitor.h

Loading...

languages/cpp/parser/rpp/pp-engine.h

Loading...

languages/cpp/parser/rpp/pp-environment.h

Loading...

languages/qmljs/codecompletion/context.h

Loading...

languages/qmljs/codecompletion/context.cpp

Loading...

languages/qmljs/duchain/declarationbuilder.h

Loading...

languages/qmljs/duchain/expressionvisitor.h

Loading...

languages/qmljs/duchain/usebuilder.h

Loading...

projectmanagers/cmake/duchain/usebuilder.h

Loading...

projectmanagers/cmake/parser/cmakelistsparser.cpp

Loading...

projectmanagers/cmake/parser/cmakeprojectvisitor.h

Loading...

projectmanagers/cmake/parser/cmakeprojectvisitor.cpp

Loading...

projectmanagers/cmake/parser/variablemap.h

Loading...

projectmanagers/qmake/parser/CMakeLists.txt

Loading...

projectmanagers/qmake/parser/buildastvisitor.h

Loading...

projectmanagers/qmake/parser/qmakelexer.h

Loading...

projectmanagers/qmake/qmakefile.h

Loading...

providers/kdeprovider/kdeprojectsreader.h

Loading...