Differential D27485

IncidenceEditor: fallback to default collection (calendar)
ClosedPublic
Actions

Authored by winterz on Feb 18 2020, 7:17 PM.

Details

Reviewers
mlaurent
dvratil
Commits
R78:729c12d21e8d: incidencedialog.cpp - fallback to default collection
Summary

In the case that we don't have a valid collection for the calendar selector we can try to fallback to the default collection

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
winterz created this revision.Feb 18 2020, 7:17 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptFeb 18 2020, 7:17 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
winterz requested review of this revision.Feb 18 2020, 7:17 PM
winterz updated this revision to Diff 75938.Feb 18 2020, 7:20 PM

forgot to set the last resort condition.

winterz updated this revision to Diff 75939.Feb 18 2020, 7:44 PM

one more try.
actually, this could be refactored.

winterz updated this revision to Diff 75940.Feb 18 2020, 7:53 PM
mlaurent requested changes to this revision.Feb 19 2020, 9:22 AM
mlaurent added inline comments.
src/incidencedialog.cpp
790

it seems to be 2 same code.
Please create a methods for removing this duplicate code.
Thanjks

This revision now requires changes to proceed.Feb 19 2020, 9:22 AM
winterz updated this revision to Diff 76130.Feb 21 2020, 10:12 PM

refactored

mlaurent accepted this revision.Feb 22 2020, 9:22 AM
This revision is now accepted and ready to land.Feb 22 2020, 9:22 AM
Closed by commit R78:729c12d21e8d: incidencedialog.cpp - fallback to default collection (authored by winterz). · Explain WhyFeb 22 2020, 2:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/incidencedialog.cpp (17 lines)

Diff 75940

View Options

src/incidencedialog.cpp

Loading...