ok, so testing this now...

1. Add new keyframe in the animation curves docker doesn't work. Doing new opacity-keyframe via the regular animation docker does work.
2. I cannot see any curves in the editor when doing a simple frame 1 to 3 fade-out with two opacity frames. The terminal spits out the following:

QPainterPath::arcTo: Adding arc where a parameter is NaN, results are undefined

It does this about a gazillion times. I have the curves docker undocked, but I doubt this has any effect on the code.

1. Labeling, saving and loading goes fine, except that once you start labeling, the subsequent keyframes you make are also labeled. Is this intentional?
2. animating the pixel values of transparency, filter and fill layers/masks seems to work okay here.

also, reviewers :)

In D2801#52160, @woltherav wrote:

ok, so testing this now...

1. Add new keyframe in the animation curves docker doesn't work. Doing new opacity-keyframe via the regular animation docker does work.

Yes I noticed that, except I also noticed the add keyframe button does work after creating (two initial points) a point on the first frame from the animation docker.

1. I cannot see any curves in the editor when doing a simple frame 1 to 3 fade-out with two opacity frames...

Yes, first you have to click Custom interpolation on a node to access the tangent curve to manipulate it.

1. Labeling, saving and loading goes fine, except that once you start labeling, the subsequent keyframes you make are also labeled. Is this intentional?

Yes this is intentional, we discussed this at the sprint (imagine you start doing keyframes.. set a color, then all next new keyframes have this color.. then you switch to another color when starting inbetweens, etc...)

1. animating the pixel values of transparency, filter and fill layers/masks seems to work okay here.

Another little issue I have with the animation curve docker: the values displayed vertically (on the left side of the graph) don't make any sense (opacity 0 is around 100, and opacity 100 around 400...

In D2801#52160, @woltherav wrote:

1. Add new keyframe in the animation curves docker doesn't work. Doing new opacity-keyframe via the regular animation docker does work.
2. I cannot see any curves in the editor when doing a simple frame 1 to 3 fade-out with two opacity frames. The terminal spits out the following: ` QPainterPath::arcTo: Adding arc where a parameter is NaN, results are undefined ` It does this about a gazillion times. I have the curves docker undocked, but I doubt this has any effect on the code.

That sounds strange. I haven't seen this bug before, nor can I replicate it. Can you replicate it reliably?

In D2801#52166, @timotheegiet wrote:

Another little issue I have with the animation curve docker: the values displayed vertically (on the left side of the graph) don't make any sense (opacity 0 is around 100, and opacity 100 around 400...

Yes, it looks like there's something wrong with the ruler numbers. I'll look into it.

I can reliably reproduce the same error message with these steps:

-New file, create one or two frames on layer2
-Go on frame 6, create new opacity keyframe from animation docker
-Go on frame 3, add a keyframe from the curve docker button

You can see it makes a vertical red line at frame 3 on the graph, but doesn't make an actual node.. like a ghost node or something.. and immediatly I get these messages in the log:
QPainterPath::arcTo: Adding arc where a parameter is NaN, results are undefined