Differential D23571

Replace obsolete methods with non-obsolete ones
ClosedPublic
Actions

Authored by yurchor on Aug 29 2019, 5:58 PM.

Details

Reviewers
mutlaqja
Group Reviewers
KStars
Commits
R321:9a3ab3221120: Replace obsolete methods with non-obsolete ones
Summary

Replace the obsolete methods from this list

https://build.kde.org/job/Extragear/job/kstars/job/kf5-qt5%20FreeBSDQt5.13/74/warnings12Result/NORMAL/category.2119183113/

by the standard scheme from other KDE applications. The metods which can increase the Qt version dependency were not replaced.

Test Plan
  1. Compiles and inastalls.
  2. Needs more testing as I don't have a telescope.

Diff Detail

Repository
R321 KStars
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15838
Build 15856: arc lint + arc unit
yurchor created this revision.Aug 29 2019, 5:58 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptAug 29 2019, 5:58 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
yurchor requested review of this revision.Aug 29 2019, 5:58 PM
mutlaqja added a subscriber: mutlaqja.Aug 29 2019, 9:05 PM
mutlaqja added inline comments.
kstars/fitsviewer/fitsviewer.cpp
243–244

The change in here results in missing filters in the GUI menu. Not sure why?

yurchor updated this revision to Diff 64974.Aug 30 2019, 6:29 AM

Fix action list in the "View" menu, remove leftovers of QSignalMapper

yurchor marked an inline comment as done.Aug 30 2019, 6:30 AM
mutlaqja accepted this revision.Aug 30 2019, 9:54 AM
This revision is now accepted and ready to land.Aug 30 2019, 9:54 AM
Closed by commit R321:9a3ab3221120: Replace obsolete methods with non-obsolete ones (authored by yurchor, committed by mutlaqja). · Explain WhyAug 30 2019, 9:55 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 64974

View Options

kstars/auxiliary/QRoundProgressBar.cpp

Loading...
View Options

kstars/auxiliary/imageviewer.cpp

Loading...
View Options

kstars/auxiliary/thumbnailpicker.cpp

Loading...
View Options

kstars/auxiliary/xplanetimageviewer.cpp

Loading...
View Options

kstars/fitsviewer/fitsdata.cpp

Loading...
View Options

kstars/fitsviewer/fitsviewer.cpp

Loading...
View Options

kstars/kspopupmenu.cpp

Loading...
View Options

kstars/oal/execute.cpp

Loading...
View Options

kstars/tools/calendarwidget.cpp

Loading...
View Options

kstars/tools/eqplotwidget.cpp

Loading...
View Options

kstars/tools/obslistwizard.cpp

Loading...
View Options

kstars/tools/skycalendar.cpp

Loading...