Differential D23142

Remove custom menu positioning code
ClosedPublic
Actions

Authored by gladhorn on Aug 14 2019, 7:31 AM.

Details

Reviewers
zzag
Group Reviewers
KWin
Commits
R108:1296ad39865c: Remove custom menu positioning code
Summary

Qt will position the menu just fine, this is overhead.
No matter how hard I tried, I couldn't get the menu to show up in a
position where it wasn't shown entirely, removing this should be safe.
Suggested by zzag.

Diff Detail

Repository
R108 KWin
Branch
master
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 15071
Build 15089: arc lint + arc unit
gladhorn created this revision.Aug 14 2019, 7:31 AM
Restricted Application added a project: KWin. · View Herald TranscriptAug 14 2019, 7:31 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
gladhorn requested review of this revision.Aug 14 2019, 7:31 AM
zzag accepted this revision.Aug 14 2019, 9:42 AM
zzag added a subscriber: zzag.
zzag added inline comments.
useractions.cpp
164

This can be simplified to m_menu->popup(pos.bottomLeft());

This revision is now accepted and ready to land.Aug 14 2019, 9:42 AM
Closed by commit R108:1296ad39865c: Remove custom menu positioning code (authored by gladhorn). · Explain WhyAug 14 2019, 9:50 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Museractions.cpp (9 lines)

Diff 63694

View Options

useractions.cpp

Loading...