Differential D22811

WIP: wayland: Implement maximized horizontal/vertical states
AbandonedPublic
Actions

Authored by zzag on Jul 29 2019, 4:07 PM.

Details

Reviewers
None
Summary

BUG: 407793

Diff Detail

Repository
R108 KWin
Branch
wayland-max-vert-horiz
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 14546
Build 14564: arc lint + arc unit
zzag created this revision.Jul 29 2019, 4:07 PM
Restricted Application added a project: KWin. · View Herald TranscriptJul 29 2019, 4:07 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Jul 29 2019, 4:07 PM
zzag added a comment.Jul 29 2019, 4:08 PM

I need to refactor state tracking logic in ShellClient before merging this patch.

zzag retitled this revision from WIP: [wayland] Implement maximized horizontal/vertical states to WIP: wayland: Implement maximized horizontal/vertical states.Jul 30 2019, 1:24 PM
meven added a subscriber: meven.Feb 5 2020, 9:15 AM

ping has ShellClient state's tracking been refactored ?

zzag added a comment.Feb 5 2020, 9:26 AM
In D22811#606264, @meven wrote:

ping has ShellClient state's tracking been refactored ?

I had made a couple of attempts to refactor the code, but in each case it turned out to be super ugly, no sane person would ever write such code. The problem is that our kwayland wrappers are not really good and they hide way too many stuff. For example, the existence of xdg-surface is completely hidden. Fixing this is on my todo list.

zzag planned changes to this revision.Feb 5 2020, 9:31 AM
zzag abandoned this revision.Sep 10 2020, 11:03 AM

Revision Contents
Changeset List

Diff 62748

View Options

autotests/integration/shell_client_test.cpp

Loading...
View Options

shell_client.cpp

Loading...