[GreeterApp] Set wallpaperGraphicsObject to what the code actually expects
ClosedPublic

Authored by broulik on Aug 24 2016, 1:40 PM.

Details

Summary

When setting the view geometries, the code tries to ensure the wallpaper is loaded at the correct size already by completing initialization of the view with correct arguments. This codepath is never executed, however, as the property contains the rootObject instead of the actually expected QmlObjectSharedEngine.

Moreover, accessing rootObject() with initializationDelayed will force completion right away.

This patch fixes the flickering of the wallpaper plugin which reloads the because the view size changed after it has loaded an image.

Test Plan

Locked my screen, no more flickering one second after the lockscreen showed up.

Still flickers in test mode as it first sets the size the view geometry (which equals the screen) but then only does a "show" in this case and so the window is maximized and the resulting anchors.fill changes the size of the wallpaper again.

Diff Detail

Repository
R133 KScreenLocker
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik updated this revision to Diff 6220.Aug 24 2016, 1:40 PM
broulik retitled this revision from to [GreeterApp] Set wallpaperGraphicsObject to what the code actually expects.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R133 KScreenLocker.
Restricted Application added a project: Plasma. · View Herald TranscriptAug 24 2016, 1:40 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik updated this object.Aug 24 2016, 1:40 PM
broulik updated this object.
graesslin accepted this revision.Aug 24 2016, 2:19 PM
graesslin added a reviewer: graesslin.
This revision is now accepted and ready to land.Aug 24 2016, 2:19 PM
This revision was automatically updated to reflect the committed changes.