Differential D21603

QXmlSimpleReader uses qt-project.org as namespace these days
AbandonedPublic
Actions

Authored by kossebau on Jun 5 2019, 2:09 PM.

Details

Reviewers
shaforostoff
sdepiets
Summary

Given the default value is true, the namespace mismatch had no effect
currently.

Diff Detail

Repository
R456 Lokalize
Branch
fixfeaturenidnamespace
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12432
Build 12450: arc lint + arc unit
kossebau requested review of this revision.Jun 5 2019, 2:09 PM
kossebau created this revision.
adrianchavesfernandez added a subscriber: adrianchavesfernandez.Jul 21 2019, 1:12 PM

If it is the default behavior, what if we simply remove those lines, to simplify the code base?

kossebau added a comment.Jul 21 2019, 1:40 PM

Removin the lines is also an option :) But not my code, so maintainers might prefer explicit setting.

kossebau abandoned this revision.Nov 29 2019, 6:47 PM

Changes committed meanwhile by 418bb8512006 & a4907aac93f3

Revision Contents
Changeset List

PathPackages
Mscripts/xliffmerge.py (2 lines)
Msrc/glossary/glossary.cpp (2 lines)

Diff 59198

View Options

scripts/xliffmerge.py

Loading...
View Options

src/glossary/glossary.cpp

Loading...