Unify i18n strings from QML to allow extraction
ClosedPublic

Authored by ltoscano on Aug 1 2016, 12:15 AM.

Details

Summary

Apparently adding strings on multiple lines does not allow them to be
extracted by our gettext invocations. So unify the long strings, but at
the same time break them into different labels to make shorter single
items.

Test Plan

Checked at least the debug area messages.

Diff Detail

Repository
R33 KDevPlatform
Branch
5.0
Lint
No Linters Available
Unit
No Unit Test Coverage
ltoscano updated this revision to Diff 5590.Aug 1 2016, 12:15 AM
ltoscano retitled this revision from to Unify i18n strings from QML to allow extraction.
ltoscano updated this object.
ltoscano edited the test plan for this revision. (Show Details)
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptAug 1 2016, 12:15 AM

I'm ashamed to say that I could not see an easy way to trigger the review page.

Please note that I targeted this to 5.0: even if the release is close, I'm not sure about the string freeze status, and those strings have never been extracted so far, not before commit 38d6cd17fd37c0504c6df2c048edf0ea024851b6 (they will be extracted in few hours), so better fix them now.

Other possibilities, if you want to avoid the double Label: a unique big string for each of the widget.

apol accepted this revision.Aug 1 2016, 12:44 AM
apol added a reviewer: apol.
This revision is now accepted and ready to land.Aug 1 2016, 12:44 AM
This revision was automatically updated to reflect the committed changes.