Differential D20336

Simplifying class constructor with constructor delegate
ClosedPublic
Actions

Authored by andreagenor on Apr 7 2019, 6:29 AM.

Details

Reviewers
tcanabrava
Commits
R374:c8984f3eed88: Simplifying class constructor with constructor delegate
Summary

Signed-off-by: André Agenor <andreagenor@icloud.com>
This is a way to avoid errors and remove duplicate code

Diff Detail

Repository
R374 KolourPaint
Branch
fix/constructor-delegate
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10551
Build 10569: arc lint + arc unit
andreagenor requested review of this revision.Apr 7 2019, 6:29 AM
andreagenor created this revision.
tcanabrava added a comment.Apr 8 2019, 1:54 PM

that looks factually wrong. what are you trying to accomplish here?

tcanabrava accepted this revision.Apr 8 2019, 1:56 PM

sorry, my mistake. this is correct.
https://en.cppreference.com/w/cpp/language/initializer_list#Delegating_constructor

I never seen this before. :)

This revision is now accepted and ready to land.Apr 8 2019, 1:56 PM
Closed by commit R374:c8984f3eed88: Simplifying class constructor with constructor delegate (authored by andreagenor). · Explain WhyApr 9 2019, 1:32 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 55625

View Options

commands/imagelib/effects/kpEffectInvertCommand.cpp

Loading...