Differential D2263

Add possible border handling in minimize all script
ClosedPublic
Actions

Authored by davidedmundson on Jul 22 2016, 1:11 PM.

Details

Reviewers
graesslin
Group Reviewers
Plasma
Commits
R108:530682f7b827: Add possible border handling in minimize all script
Summary

Adds screen edge handling in minimize all script.

Test Plan

With a hacked KCM, setting the option works perfectly and updates correctly
adding/removing the edge bindings as appropriate.

Diff Detail

Repository
R108 KWin
Lint
No Linters Available
Unit
No Unit Test Coverage
davidedmundson updated this revision to Diff 5442.Jul 22 2016, 1:11 PM
davidedmundson retitled this revision from to Add possible border handling in minimize all script.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: KWin. · View Herald TranscriptJul 22 2016, 1:11 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
graesslin added a subscriber: graesslin.Jul 22 2016, 2:19 PM
graesslin added inline comments.
scripts/minimizeall/contents/code/main.js
67–69

minor nitpick: this looks strante

davidedmundson updated this revision to Diff 5447.Jul 22 2016, 2:40 PM

Fix whitespace problems

graesslin accepted this revision.Jul 22 2016, 4:16 PM
graesslin added a reviewer: graesslin.
This revision is now accepted and ready to land.Jul 22 2016, 4:16 PM
Closed by commit R108:530682f7b827: Add possible border handling in minimize all script (authored by davidedmundson). · Explain WhyOct 7 2016, 2:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 5447

View Options

scripts/minimizeall/contents/code/main.js

Loading...