Differential D19436

[kservice] compile without deprecated method
ClosedPublic
Actions

Authored by mlaurent on Mar 1 2019, 6:05 AM.

Details

Reviewers
dfaure
Commits
R309:45337a4c28c3: [kservice] compile without deprecated method
Summary

compile without deprecated method

Test Plan

autotest ok

Diff Detail

Repository
R309 KService
Branch
compile_without_deprecated_method (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9094
Build 9112: arc lint + arc unit
mlaurent created this revision.Mar 1 2019, 6:05 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 1 2019, 6:05 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
mlaurent requested review of this revision.Mar 1 2019, 6:05 AM
dfaure requested changes to this revision.Mar 1 2019, 8:30 AM
dfaure added inline comments.
autotests/ksycocathreadtest.cpp
306

This doesn't truncate milliseconds anymore....

You should port toTime_t to toSecsSinceEpoch (no 'M')

This revision now requires changes to proceed.Mar 1 2019, 8:30 AM
mlaurent updated this revision to Diff 53011.Mar 2 2019, 5:03 PM

Use toSecsSinceEpoch

dfaure accepted this revision.Mar 2 2019, 5:13 PM
This revision is now accepted and ready to land.Mar 2 2019, 5:13 PM
Closed by commit R309:45337a4c28c3: [kservice] compile without deprecated method (authored by mlaurent). · Explain WhyMar 2 2019, 6:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 53011

View Options

CMakeLists.txt

Loading...
View Options

autotests/kmimeassociationstest.cpp

Loading...
View Options

autotests/ksycocathreadtest.cpp

Loading...
View Options

src/services/kservicetypeprofile.cpp

Loading...
View Options

src/sycoca/kbuildservicefactory.cpp

Loading...
View Options

src/sycoca/kbuildsycoca.cpp

Loading...