Just set UDSEntry::UDS_NAME to the actual directory name instead of the hardcoded string "folder" and don't set UDSEntry::UDS_DISPLAY_NAME at all
ClosedPublic
Actions

Authored by eduisters on Jan 13 2019, 1:53 PM.

Details

Reviewers

albertvaka

Group Reviewers

KDE Connect

Commits

Summary

There is no reason to set UDSEntry::UDS_NAME to "folder" and then override it with UDSEntry::UDS_DISPLAY_NAME

Test Plan

Apply patch, click android device in dolphin's Devices list
Verify phones sdcards are listed as befor

Repository

R224 KDE Connect

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kdeconnect. · View Herald Transcript

eduisters requested review of this revision.Jan 13 2019, 1:53 PM

Makes sense. Probably this was copied-and-pasted from another KIOslave.

kio/kiokdeconnect.cpp
92	It can still be accessed through `kdeconnect://` without a device id following.

This revision is now accepted and ready to land.Jan 16 2019, 12:05 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			kio/kiokdeconnect.cpp (4 lines)
M			plugins/sftp/sftpplugin.cpp (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	49382	0b1fbde		Jan 13 2019, 1:53 PM	★	★
Diff 2	49632	708262e	R224:4834b635377807e07e45bc4b1b9fcbacb05628c5	Jan 16 2019, 1:56 PM	★	★