Import CMSYS dependency
ClosedPublic
Actions

Authored by kfunk on Jun 15 2016, 7:21 AM.

Details

Reviewers: None
Commits: R32:3477bb7783b6: Import CMSYS dependency

Summary

Don't depend on the external library. Just requires a minor patch in the
cmListFileLexer code, this is worth it. Doesn't need a special version
of CMake which installs the internal CMSYS lib then.

Diff Detail

Repository

R32 KDevelop

Branch

5.0

Lint

No Linters Available

Unit

No Unit Test Coverage

kfunk updated this revision to Diff 4485.Jun 15 2016, 7:21 AM

kfunk retitled this revision from to Import CMSYS dependency.

kfunk updated this object.

kfunk edited the test plan for this revision. (Show Details)

Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJun 15 2016, 7:21 AM

kfunk added a subscriber: arrowd.Jun 15 2016, 7:27 AM

arrowd added inline comments.Jun 15 2016, 8:07 AM

projectmanagers/cmake/parser/cmListFileLexer.in.l
508	I'd better #define `cmsysEncoding_DupToWide` to `kwsysEncoding_DupToWide` in the `#ifdef Win32` above. This would consolidate our changes to the lexer in one place.

Closed by commit R32:3477bb7783b6: Import CMSYS dependency (authored by kfunk). · Explain WhyJun 15 2016, 9:45 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		projectmanagers/cmake/CMakeLists.txt (6 lines)
A	M	projectmanagers/cmake/parser/EncodingC.c (85 lines)
M		projectmanagers/cmake/parser/cmListFileLexer.c (5 lines)
M		projectmanagers/cmake/parser/cmListFileLexer.in.l (5 lines)