Differential D16531

Add keyboard shortcuts for changing from currect worksheet to next/prevous
ClosedPublic
Actions

Authored by sirgienko on Oct 30 2018, 5:31 PM.

Details

Reviewers
asemke
filipesaraiva
Commits
R55:6ce8b4f51444: Add shortcuts for change worksheet tab: Ctrl+PageUp - go to next worksheet tab…
Summary

Add shortcuts for change worksheet tab: Ctrl+PageUp - go to next worksheet tab, Ctrl+PageDown - go to previous worksheet tab

Diff Detail

Repository
R55 Cantor
Branch
add-tabs-shortcuts
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4350
Build 4368: arc lint + arc unit
sirgienko created this revision.Oct 30 2018, 5:31 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptOct 30 2018, 5:31 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
sirgienko requested review of this revision.Oct 30 2018, 5:31 PM
asemke added inline comments.Oct 30 2018, 5:56 PM
src/cantor.cpp
133

Can we also consider the case index < 0 and navigate to the last tab? This would be similar for example to the behavior in Konsole or in Firefox and maybe in many other programms.

144

Similar here for the case index == m_tabWidget->count().

sirgienko updated this revision to Diff 44505.Oct 30 2018, 6:30 PM

Added cyclic moving for tabs

sirgienko marked 2 inline comments as done.Oct 30 2018, 6:30 PM
sirgienko updated this revision to Diff 44506.Oct 30 2018, 6:32 PM

Small improvments (change else if to else)

asemke accepted this revision.Oct 30 2018, 8:45 PM
This revision is now accepted and ready to land.Oct 30 2018, 8:45 PM
Closed by commit R55:6ce8b4f51444: Add shortcuts for change worksheet tab: Ctrl+PageUp - go to next worksheet tab… (authored by sirgienko). · Explain WhyOct 30 2018, 9:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/cantor.cpp (24 lines)

Diff 44506

View Options

src/cantor.cpp

Loading...