Compiles and still works.
Details
- Reviewers
davidedmundson - Group Reviewers
KWin - Commits
- R108:91ddeea7503f: [effects/coverswitch] Port to TimeLine
Diff Detail
- Repository
- R108 KWin
- Branch
- effects-coverswitch-port-to-timeline
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 2553 Build 2571: arc lint + arc unit
effects/coverswitch/coverswitch.cpp | ||
---|---|---|
406 | one set of parentheses seems redundant | |
545 | it'll be a bigger refactor, but would it be more in line with Timeline to do .setDirection() (maybe afterwards) then we can kill all the data.setOpacity(1.0 - timeLine.currentValue()); if (stop) data.setOpacity(timeLine.currentValue()); everywhere. | |
550–554 | we should reset the timeline here If animateStart is on and animateStop is off and a user cancels halfway through the load, we become inactive straight away and won't hit the main cleanup. | |
744 | I know you've not touched this, but should these two lines be wrapped in && timeLine.value < 0.5 | |
922–923 | should we not reset the timeline here? |
effects/coverswitch/coverswitch.cpp | ||
---|---|---|
406 | Well, I didn't add them. Yeah, probably, that's okay to delete them. | |
545 | Yes, it would be nice to just toggle direction. That's not really cool that effects call setCurrentTime/setElapsed(in fact, it's discouraged to call setElapsed). | |
550–554 | Probably, we also have to reset start. | |
744 | Probably, I also was wondering why opacity is ranging from -1 to 1. |