Differential D15250

Remove a warning.
ClosedPublic
Actions

Authored by woltherav on Sep 3 2018, 5:08 PM.

Details

Reviewers
leinir
Commits
R157:98e1852a3d14: Remove warning in book.qml
Summary

This removes a warning that pops up when pressing "<-" past the cover to view the book info. Somehow, it also made it possible to see the bookinfo on books that didn't have much of that.

This is the first qml file I've ever touched, but I think it is ok.

Diff Detail

Repository
R157 Peruse
Lint
Lint Skipped
Unit
Unit Tests Skipped
woltherav requested review of this revision.Sep 3 2018, 5:08 PM
woltherav created this revision.
woltherav edited the summary of this revision. (Show Details)
leinir accepted this revision.Sep 4 2018, 7:04 AM

That is indeed correct, well done on your first bit of QML! :D

This revision is now accepted and ready to land.Sep 4 2018, 7:04 AM
Closed by commit R157:98e1852a3d14: Remove warning in book.qml (authored by woltherav). · Explain WhySep 4 2018, 7:31 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/app/qml/Book.qml (4 lines)

Diff 40930

View Options

src/app/qml/Book.qml

Loading...