Differential D15246

Allow checking against the new ACBF namespaces as well.
ClosedPublic
Actions

Authored by woltherav on Sep 3 2018, 2:48 PM.

Details

Reviewers
leinir
Commits
R157:84c696323bd8: Let ACBF documents with the new namespace be read as well.
Summary

ACBF moved its namespace location for 1.1 and up, so lets approve those documents to be loaded as well.

NB: We should proly also not load textfiles as images in archivebookmodel, but that might be better as a separate patch.

Test Plan

Try loading this file without and with this patch.

I_don't_know.cbz1 MBDownload

Diff Detail

Repository
R157 Peruse
Lint
Lint Skipped
Unit
Unit Tests Skipped
woltherav requested review of this revision.Sep 3 2018, 2:48 PM
woltherav created this revision.
leinir accepted this revision.Sep 4 2018, 7:03 AM

LGTM! (and yes, that NB does sound rather like another patch - i'll have a look at that, likely make sense to ask Qt what image formats it supports and then use that, which also needs to happen elsewhere (specifically in the folderofimages type) :) )

This revision is now accepted and ready to land.Sep 4 2018, 7:03 AM
Closed by commit R157:84c696323bd8: Let ACBF documents with the new namespace be read as well. (authored by woltherav). · Explain WhySep 4 2018, 7:31 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/acbf/AcbfDocument.cpp (4 lines)

Diff 40921

View Options

src/acbf/AcbfDocument.cpp

Loading...