Differential D1692

kfontinst: Port away from Kdelibs4Support
ClosedPublic
Actions

Authored by volkov on May 26 2016, 2:29 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R119:c2944ed823ad: kfontinst: Port away from Kdelibs4Support
Summary
  • get rid of KGlobal and KLocale
  • get rid of KComponentData
  • port to QTemporaryFile
  • port to Q_GLOBAL_STATIC
  • port to Q_DECL_EXPORT/Q_DECL_IMPORT
  • reorder includes to avoid including fixx11.h

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
volkov updated this revision to Diff 4012.May 26 2016, 2:29 PM
volkov retitled this revision from to kfontinst: Port away from Kdelibs4Support.
volkov updated this object.
volkov edited the test plan for this revision. (Show Details)
volkov added a reviewer: Plasma.
volkov set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma. · View Herald TranscriptMay 26 2016, 2:29 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.May 26 2016, 3:19 PM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.May 26 2016, 3:19 PM
volkov added a comment.May 27 2016, 10:11 AM

Please, review also https://phabricator.kde.org/D1691 , because this change depends on it.

Closed by commit R119:c2944ed823ad: kfontinst: Port away from Kdelibs4Support (authored by volkov). · Explain WhyJun 1 2016, 8:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 4012

View Options

kcms/kfontinst/apps/CMakeLists.txt

Loading...
View Options

kcms/kfontinst/apps/CreateParent.h

Loading...
View Options

kcms/kfontinst/dbus/CMakeLists.txt

Loading...
View Options

kcms/kfontinst/dbus/Folder.cpp

Loading...
View Options

kcms/kfontinst/kcmfontinst/CMakeLists.txt

Loading...
View Options

kcms/kfontinst/kcmfontinst/DuplicatesDialog.cpp

Loading...
View Options

kcms/kfontinst/kcmfontinst/JobRunner.cpp

Loading...
View Options

kcms/kfontinst/kcmfontinst/KCmFontInst.cpp

Loading...
View Options

kcms/kfontinst/kio/KioFonts.cpp

Loading...
View Options

kcms/kfontinst/lib/CMakeLists.txt

Loading...
View Options

kcms/kfontinst/lib/FcEngine.cpp

Loading...
View Options

kcms/kfontinst/lib/WritingSystems.cpp

Loading...
View Options

kcms/kfontinst/lib/kfontinst_export.h

Loading...
View Options

kcms/kfontinst/thumbnail/FontThumbnail.h

Loading...
View Options

kcms/kfontinst/viewpart/FontViewPart.cpp

Loading...