Remove code moved to PluginManager
ClosedPublic
Actions

Authored by elvisangelaccio on Apr 27 2016, 4:23 PM.

Details

Reviewers

Commits

Summary

This patch removes the duplicated code in mimetypes.cpp. This code was moved and simplified in the new PluginManager class.

Test Plan

With the following in arkrc

[EnabledPlugins]
kerfuffle_clirar=false

the rar mimetype will not show up in the CreateDialog (because cliunarchiver will become the preferred plugin for rar).

Repository

R36 Ark

Lint

Lint Skipped

Unit

Unit Tests Skipped

elvisangelaccio retitled this revision from to Remove code moved to PluginManager.

elvisangelaccio updated this object.

elvisangelaccio edited the test plan for this revision. (Show Details)

elvisangelaccio set the repository for this revision to R36 Ark.

elvisangelaccio added a project: Ark.

Looks good :)

This revision is now accepted and ready to land.Apr 27 2016, 4:48 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			app/extractHereDndPlugin.cpp (5 lines)
M			app/mainwindow.cpp (12 lines)
M			autotests/kerfuffle/createdialogtest.cpp (15 lines)
M			kerfuffle/createdialog.h (4 lines)
M			kerfuffle/createdialog.cpp (7 lines)
M			kerfuffle/mimetypes.h (34 lines)
M			kerfuffle/mimetypes.cpp (138 lines)