Checking whether m_topLevel is not null before getting its property
AbandonedPublic

Authored by ivan on Apr 7 2016, 5:25 PM.

Details

Reviewers
graesslin
Summary

This method checks whether m_topLevel is not null in a couple
of places, but misses this one.

p.s. If there are more places where kwin does clear_or_something(); return;
it could benefit from introducing on_scope_exit and similar tricks - see
Alexandrescu's 'Declarative control flow' presentation.

Diff Detail

Repository
R108 KWin
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
ivan updated this revision to Diff 3194.Apr 7 2016, 5:25 PM
ivan retitled this revision from to Checking whether m_topLevel is not null before getting its property.
ivan updated this object.
ivan edited the test plan for this revision. (Show Details)
ivan added a reviewer: graesslin.
Restricted Application added a project: Plasma. · View Herald TranscriptApr 7 2016, 5:25 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ivan updated this revision to Diff 3195.Apr 7 2016, 5:31 PM
  • m_textTexture can be null even after updateTextTexture()
ivan abandoned this revision.Apr 7 2016, 5:34 PM

Damn, arc merged these two, will recreate