craftenv.sh: Don't export environment variables starting with BASH_FUNC_
ClosedPublic

Authored by arichardson on Mar 17 2018, 6:42 PM.

Details

Summary

Otherwise I get the following warning:
bash: export: BASH_FUNC_generate_command_executed_sequence%%=()': not a valid identifier`

It turns out I have the following variable in my environment:

BASH_FUNC_generate_command_executed_sequence%%=() {  printf '\e\7'
}
Test Plan

I no longer get the warning when sourcing craftenv.sh

Diff Detail

Repository
R138 Craft
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
arichardson requested review of this revision.Mar 17 2018, 6:42 PM
arichardson created this revision.

Hm I think we should keep the sh as small as possible and the code in the py should be sufficient?

remove from .sh file

vonreth accepted this revision.Mar 22 2018, 11:23 AM
This revision is now accepted and ready to land.Mar 22 2018, 11:23 AM
This revision was automatically updated to reflect the committed changes.