| graesslin |
This changes splits up the monster file containing different types used
in the DRM backend into separate files per class:
No actual code changes other than build fixes.
Clean up headers in the split files.
Builds with GBM enabled
| No Linters Available |
| No Unit Test Coverage |
Thanks for doing the split!
| backends/drm/drm_backend.cpp | ||
|---|---|---|
| 50–52 | please remove if no longer needed | |
| backends/drm/drm_backend.h | ||
| 55–57 | why are the forward declarations removed? If that compiled before the split with forward declarations instead of includes that should still be possible | |
| backends/drm/drm_buffer.cpp | ||
| 20–21 | Krazy would tell you to include own header first | |
| 24 | I don't see this one used | |
| 25–27 | I don't see this one used | |
| backends/drm/drm_inputeventfilter.h | ||
| 25 | I don't see QPointer used her | |
| 26 | I don't see any QSize in this file | |
| backends/drm/drm_output.cpp | ||
| 274–275 | Please don't push your local TODO commits | |
| 597–599 | similar | |
| backends/drm/drm_pointer.h | ||
| 23 | no QPointer in this file, though I see a QScopedPointer | |
| backends/drm/scene_qpainter_drm_backend.cpp | ||
| 53–58 | unrelated to the split | |
I would say so, at least in my hacking sessions, I have tons of files called output, backend, etc., so for me personally, it's actually very convenient.
There are still a few unrelated changes included and some not-needed includes in header files
| backends/drm/drm_buffer.h | ||
|---|---|---|
| 25 | I don't see QPointer used | |
| backends/drm/drm_output.h | ||
| 24 | either forward declare (see below the forward declaration for DrmBackend) or include, not both :-) I assume that forward declaration should be sufficient here. | |
| backends/drm/drm_pointer.h | ||
| 24 | QPointer not used in this file | |
| backends/drm/scene_qpainter_drm_backend.cpp | ||
| 54–58 | still unrelated | |