Same

why you add theses changes in this review §?

So ? do you still have error ?

Same for name as you use it all the time create a variable for it

it's better to compare "variable" to value

> QCompare(spy.count(), 1)

Fails ? which is the problem ?

same QCompare(value, 1); fix all others QCOMPARE if necessary

it's value compare with expected

when it failed you can see correct debug

you still use input.append(QJsonValue(QLatin1String("removed"))); so it's correct no.
If it found "removed" it will remove it will not added no ?

otherwise you need to need to have QStringLiteral("inserted")

readOnly true...
it's wierd.... we need to know why it's readonly

yep todo

? what is the error?

We need to do it because for the moment yep we use this code:
" const QJsonObject fields = object.value(QLatin1String("fields")).toObject();

setName(fields.value(QLatin1String("name")).toString());
setUserId(object.value(QLatin1String("id")).toString());
setStatus(fields.value(QLatin1String("status")).toString());"

so we know that we use setName/setStatus etc.
but perhaps in the future we will change and assign directly as value

> signal will not emit and it will be an error

> test signal too.

!= please :)

qCDebug(...)

So you need to test that pointer is null here.
Otherwise it's not necessary to use findRoom if you don't test value.

But I prefere that we check this value

Good for testing default value but please add a test when it's not default value too thanks.

QCOMPARE(current value, expected) same for other QCOMPARE

If we don't find roomId we mustn't create a new RoomWrapper.
We need to check nullptr in return value otherwise we will create a not existing room.

qCDebug(debug categori") and uncomment it please.

heu... return !User::operator(User) it doesn't work ?
We don't need to add duplicate code.

compare with selected value no ?

QCOMPARE(..., favorite)

QCOMPARE(value, expected)

QCOMPARE(value, expected) please verify each QCOMPARe

RUQOLA_LOG without () I know that it compiles but we use by default without () same for others code

Remove all this code....

Please create several branch where you put specific code as autotests and and other one for qmlFileTestResources

git checkout -b add_autotest_room_model for this one

and git checkout -b add_qmltest for other one.

Please rebase from master I changed a lot of thing.