velurimithun (Veluri Mithun)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Dec 13 2017, 3:38 AM (96 w, 1 d)
Availability
Available

Recent Activity

Feb 13 2018

velurimithun added a comment to D10154: OAuth support for Ruqola.

Really there is something wrong with Qt5::Keychain libraries => no need to write (Findo2.cmake)module for finding o2 package, by default, it is able to find it(since o2 libraries are built with cmake only) and our cmake is unable to link qt5Keychain which is dependency of o2

Feb 13 2018, 6:32 PM
velurimithun updated the diff for D10154: OAuth support for Ruqola.
  • Make OAuth as optional
Feb 13 2018, 6:25 PM

Feb 12 2018

velurimithun added inline comments to D10154: OAuth support for Ruqola.
Feb 12 2018, 8:37 PM
velurimithun added inline comments to D10154: OAuth support for Ruqola.
Feb 12 2018, 5:58 AM
velurimithun updated the diff for D10154: OAuth support for Ruqola.
  • Create Findo2.cmake file
Feb 12 2018, 5:50 AM

Feb 10 2018

velurimithun added inline comments to D10154: OAuth support for Ruqola.
Feb 10 2018, 9:08 PM
velurimithun updated the diff for D10154: OAuth support for Ruqola.
  • Modify code acrdg to comments
Feb 10 2018, 9:06 PM
velurimithun added inline comments to D10154: OAuth support for Ruqola.
Feb 10 2018, 7:13 PM
velurimithun updated the diff for D10154: OAuth support for Ruqola.
  • Add 'o2' static library path as Item
Feb 10 2018, 6:35 PM

Feb 8 2018

velurimithun added a comment to D10154: OAuth support for Ruqola.

/usr/bin/ld: cannot find -lQt5::Keychain

Feb 8 2018, 6:28 PM
velurimithun updated the diff for D10154: OAuth support for Ruqola.
  • Modify the code (D10154)
  • Take o2 as external lib
Feb 8 2018, 6:14 PM
velurimithun added a comment to D10154: OAuth support for Ruqola.

when I try to build Qt5::Keychain doesn't link properly and I'm getting errors...!

Feb 8 2018, 6:05 AM
velurimithun updated the diff for D10154: OAuth support for Ruqola.
  • Modify the code according to comments in Revision and now 'Login with Google' button is working perfectly
  • Try to add o2 as external lib
Feb 8 2018, 5:58 AM

Feb 6 2018

velurimithun added a comment to D10154: OAuth support for Ruqola.

I'm getting error like TypeError: Property 'setLoginType' of object [object Object] is not a function :( in login.qml file...!

Feb 6 2018, 7:42 PM
velurimithun updated the diff for D10154: OAuth support for Ruqola.
  • Add button in login.qml for OAuth
Feb 6 2018, 7:35 PM

Feb 4 2018

velurimithun updated the test plan for D10154: OAuth support for Ruqola.
Feb 4 2018, 8:46 PM
velurimithun added inline comments to D10154: OAuth support for Ruqola.
Feb 4 2018, 8:45 PM
velurimithun updated the diff for D10154: OAuth support for Ruqola.

Libraries at github.com/pipcas/o2 are used

Feb 4 2018, 8:29 PM

Feb 3 2018

velurimithun added a comment to D10154: OAuth support for Ruqola.

Did you know this !! Google stopped OAuth for embedded webViews

Feb 3 2018, 6:17 PM
velurimithun added a comment to D10154: OAuth support for Ruqola.

Yeah, I've tried by handling browser and you can see the implementation of it in our authentication.cpp class in the first diff(https://phabricator.kde.org/D10154?id=26094) in this revision only!!

Feb 3 2018, 9:07 AM

Feb 2 2018

velurimithun added a comment to D10154: OAuth support for Ruqola.

Anyway we definitely need a QWidget (like a dialog box) to take input from user from google prompt (entering google email and password) or

Feb 2 2018, 6:14 PM
velurimithun added a comment to D10154: OAuth support for Ruqola.

Yeah, I've tried it and you can see the implementation of it in our authentication.cpp class in the first diff(https://phabricator.kde.org/D10154?id=26094) in this revision only!!

Feb 2 2018, 1:51 PM

Feb 1 2018

velurimithun added a comment to D10154: OAuth support for Ruqola.

Still, Login Dialog box doesn't appear on the screen :(

Feb 1 2018, 11:30 AM
velurimithun updated the diff for D10154: OAuth support for Ruqola.
  • using ICS libraries compiling well
  • Dialog box probelm
  • make modification according to comments in arc Revision
Feb 1 2018, 11:28 AM
velurimithun added inline comments to D10154: OAuth support for Ruqola.
Feb 1 2018, 10:31 AM
velurimithun added inline comments to D10154: OAuth support for Ruqola.
Feb 1 2018, 9:14 AM

Jan 31 2018

velurimithun added a comment to D10154: OAuth support for Ruqola.

I need one more clarity that https://rocket.chat/docs/developer-guides/realtime-api/method-calls/login/ (here) under OAuth authentication section, they gave "credential_token" and "credential_secret" to pass in the method .

Jan 31 2018, 6:56 PM
velurimithun added a comment to D10154: OAuth support for Ruqola.
Jan 31 2018, 6:51 PM
velurimithun updated the diff for D10154: OAuth support for Ruqola.

Try to create Webview in authenticatin class

Jan 31 2018, 6:45 PM
velurimithun updated the diff for D10154: OAuth support for Ruqola.

Use ICS Qt libraries for Google OAuth API

Jan 31 2018, 6:00 PM

Jan 28 2018

velurimithun removed a reviewer for D10154: OAuth support for Ruqola: Ruqola.
Jan 28 2018, 6:48 AM

Jan 22 2018

velurimithun committed R244:53f3dce3f012: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII ) (authored by velurimithun).
Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )
Jan 22 2018, 12:41 PM
velurimithun closed D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII ).
Jan 22 2018, 12:41 PM · Frameworks

Jan 21 2018

velurimithun added a comment to D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII ).

In kdirwatch_qfswatch_unittest KDirWatch_UnitTest::benchNotifyWatcher() fails before and after changes in kdirwatch_unittest.cpp file

Jan 21 2018, 12:15 PM · Frameworks
velurimithun updated the diff for D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII ).
  • Compare license file correctly
Jan 21 2018, 12:09 PM · Frameworks

Jan 20 2018

velurimithun added a comment to D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII ).

Sry for the late patch :))

Jan 20 2018, 10:38 AM · Frameworks
velurimithun updated the diff for D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII ).
  • use QLating1String
  • compile commenting remove_definition(DQT_NO_CAST_FROM_ASCII
  • Make necessary changes according to comments in D9420
  • Use QString::fromUtf8(..) to decode an escape sequence like \x21
  • Merge with origin/master
  • Rewrite strings using QLatin1String() and QString::fromLatin1()
Jan 20 2018, 10:33 AM · Frameworks

Jan 18 2018

velurimithun committed R865:53b37cdb36d0: Create test app to test qml files (authored by velurimithun).
Create test app to test qml files
Jan 18 2018, 4:15 PM
velurimithun closed D9828: Create test app to test qml files.
Jan 18 2018, 4:15 PM
velurimithun added a comment to D9828: Create test app to test qml files.

Done

Jan 18 2018, 10:25 AM
velurimithun updated the diff for D9828: Create test app to test qml files.
  • use isEmpty() instead QString()
Jan 18 2018, 10:25 AM
velurimithun updated the diff for D9828: Create test app to test qml files.
  • GIT_SILENT
Jan 18 2018, 6:25 AM

Jan 17 2018

velurimithun added inline comments to D9828: Create test app to test qml files.
Jan 17 2018, 9:20 AM
velurimithun updated the diff for D9828: Create test app to test qml files.
  • Use QFileDialog
Jan 17 2018, 9:18 AM
velurimithun updated the diff for D9828: Create test app to test qml files.
  • Remove extra code
Jan 17 2018, 5:52 AM

Jan 16 2018

velurimithun updated the diff for D9828: Create test app to test qml files.
  • GIT_SILENT
Jan 16 2018, 7:00 PM
velurimithun added inline comments to D9828: Create test app to test qml files.
Jan 16 2018, 6:53 PM
velurimithun updated the diff for D9828: Create test app to test qml files.

Modify the code for dialogBox

Jan 16 2018, 6:53 PM
velurimithun updated the diff for D9828: Create test app to test qml files.
  • change dir to ":/" from "qrc:/" in add qml file
Jan 16 2018, 5:57 AM
velurimithun added a comment to D9828: Create test app to test qml files.

Please kindly check, our ruqolaRegisterEngine is not initializing , were are getting errors :/ already mentioned those in prev. comments

Jan 16 2018, 5:55 AM
velurimithun added inline comments to D9828: Create test app to test qml files.
Jan 16 2018, 5:52 AM
velurimithun updated the diff for D9828: Create test app to test qml files.
  • Add all qml files present in current dir
Jan 16 2018, 5:49 AM

Jan 15 2018

velurimithun added a comment to D9828: Create test app to test qml files.

In cmakeLists.txt also I think there is no need to target_link_libreries link QT5::widget

Jan 15 2018, 4:48 PM
velurimithun added a comment to D9828: Create test app to test qml files.

I'm getting the following error when I try to log the warning in RUQOLA_LOG although it is defined in ruqola_debug.h

Jan 15 2018, 4:40 PM
velurimithun added inline comments to D9828: Create test app to test qml files.
Jan 15 2018, 4:38 PM
velurimithun updated the diff for D9828: Create test app to test qml files.

Write else case if engine not initialized

Jan 15 2018, 4:38 PM

Jan 14 2018

velurimithun updated the diff for D9828: Create test app to test qml files.

Check the file whether it is present in qrc:/ directory

Jan 14 2018, 5:33 PM
velurimithun added a comment to D9828: Create test app to test qml files.

I'm getting following errors:

Jan 14 2018, 2:10 PM
velurimithun updated the diff for D9828: Create test app to test qml files.

Initialize ruqolaRegisterEngine

Jan 14 2018, 2:06 PM
velurimithun committed R865:1e58cc64f1e0: Add autotest for roommodel and user classes (authored by velurimithun).
Add autotest for roommodel and user classes
Jan 14 2018, 11:39 AM
velurimithun closed D9646: Add autotest for roommodel and user classes.
Jan 14 2018, 11:39 AM
velurimithun added inline comments to D9828: Create test app to test qml files.
Jan 14 2018, 8:00 AM
velurimithun updated the diff for D9828: Create test app to test qml files.

Modify the code according to commemts

Jan 14 2018, 7:59 AM

Jan 12 2018

velurimithun updated the diff for D9646: Add autotest for roommodel and user classes.
  • Undo the changes for qmlTestApp
Jan 12 2018, 10:26 AM
velurimithun updated the diff for D9646: Add autotest for roommodel and user classes.
  • Remove () after RUQOLA_LOG in qCDebug()
Jan 12 2018, 3:07 AM

Jan 11 2018

velurimithun added a comment to D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII ).

Yeah, I have rebuilt it !! NO ERRORS compiling well. I'm not getting any errors like that :/

Jan 11 2018, 6:35 PM · Frameworks
velurimithun updated the diff for D9646: Add autotest for roommodel and user classes.

Use () for qCDebug(RUQOLA_LOG) in roomModel.cpp

Jan 11 2018, 6:22 PM
velurimithun added a comment to D9828: Create test app to test qml files.

currently, we are getting errors like ..

Jan 11 2018, 6:12 PM

Jan 10 2018

velurimithun added a comment to D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII ).

StringEncodings doc helped me to understand encoding and decoding.

Jan 10 2018, 11:47 AM · Frameworks
velurimithun updated the diff for D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII ).
  • Use QString::fromUtf8(..) to decode an escape sequence like \x21
Jan 10 2018, 11:42 AM · Frameworks

Jan 9 2018

velurimithun added a comment to D9646: Add autotest for roommodel and user classes.

Fixed

Jan 9 2018, 1:52 PM
velurimithun updated the diff for D9646: Add autotest for roommodel and user classes.
  • Fix minor errors
Jan 9 2018, 1:51 PM

Jan 7 2018

velurimithun retitled D9646: Add autotest for roommodel and user classes from << Add autotest for roommodel >> to Add autotest for roommodel and user classes.
Jan 7 2018, 4:23 PM
velurimithun added inline comments to D9646: Add autotest for roommodel and user classes.
Jan 7 2018, 4:22 PM
velurimithun updated the diff for D9646: Add autotest for roommodel and user classes.
  • write non-default test cases for data method in roomModel

rewrite QCOMPARE() properly in userTest.cpp
log the print statments in roomModel to RUQOLA_LIB through qCDebug
change the findRoom method to return nullptr if it doesn't find room!

Jan 7 2018, 4:21 PM

Jan 6 2018

velurimithun updated the diff for D9646: Add autotest for roommodel and user classes.
  • Add test for data in roomModel
Jan 6 2018, 5:06 AM

Jan 5 2018

velurimithun added inline comments to D9646: Add autotest for roommodel and user classes.
Jan 5 2018, 4:30 PM
velurimithun updated the diff for D9646: Add autotest for roommodel and user classes.
  • Fix parseUpdateRoom method in room.cpp
Jan 5 2018, 4:09 PM
velurimithun added inline comments to D9646: Add autotest for roommodel and user classes.
Jan 5 2018, 8:24 AM
velurimithun added a comment to D9646: Add autotest for roommodel and user classes.

clarity on updateRoom(QJsonObject)

  • can you please tell me exactly what updateRoom should do in roomModel.cpp?
  • It should update the existing values or It should update the existing values and add new values passed through arguments.
Jan 5 2018, 8:21 AM
velurimithun updated the diff for D9646: Add autotest for roommodel and user classes.
  • Modify the code
Jan 5 2018, 8:21 AM
velurimithun added inline comments to D9646: Add autotest for roommodel and user classes.
Jan 5 2018, 5:11 AM
velurimithun updated the diff for D9646: Add autotest for roommodel and user classes.
  • Add more tests to user and roomModel
Jan 5 2018, 5:07 AM
velurimithun added inline comments to D9646: Add autotest for roommodel and user classes.
Jan 5 2018, 2:52 AM

Jan 4 2018

velurimithun updated the diff for D9646: Add autotest for roommodel and user classes.
  • Add test cases for user
Jan 4 2018, 5:57 PM
velurimithun added a comment to D9646: Add autotest for roommodel and user classes.
  • clarity on updateRoom(QJsonObject)

can you please tell me exactly what updateRoom should do in roomModel.cpp?
It should update the existing values or It should update the existing values and add new values passed through arguments.

Jan 4 2018, 2:20 PM
velurimithun updated the diff for D9646: Add autotest for roommodel and user classes.
  • Change updateRoom method in roomModel and add tests for roomModel

previous updateRomm method in roomModel(QJsonObject) was changing with name, now roomId is considered for change.

Jan 4 2018, 2:09 PM

Jan 3 2018

velurimithun added a comment to D9646: Add autotest for roommodel and user classes.
  • The order of the tests is in such a manner that, if in any currentTest Method another method is used that will be tested earlier to currentTest Method.
Jan 3 2018, 7:12 PM

Dec 30 2017

velurimithun added a comment to D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII ).

Code updated. Please let me know any changes are there yet to be done

Dec 30 2017, 5:46 PM · Frameworks
velurimithun updated the diff for D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII ).
  • Make necessary changes according to comments in D9420

Use QLatin1Char for char

Dec 30 2017, 4:22 PM · Frameworks

Dec 29 2017

velurimithun added inline comments to D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII ).
Dec 29 2017, 12:04 PM · Frameworks
velurimithun updated the diff for D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII ).

patch created for all the changes from starting

Dec 29 2017, 11:54 AM · Frameworks

Dec 21 2017

velurimithun updated the diff for D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII ).
Dec 21 2017, 3:17 PM · Frameworks
velurimithun added inline comments to D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII ).
Dec 21 2017, 6:44 AM · Frameworks
velurimithun added a comment to D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII ).

I'm getting errors in processtest!!

Dec 21 2017, 6:04 AM · Frameworks
velurimithun updated the diff for D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII ).
Dec 21 2017, 5:58 AM · Frameworks
velurimithun updated the diff for D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII ).

Update the code using QStringLiteral

Dec 21 2017, 5:49 AM · Frameworks
velurimithun updated the diff for D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII ).

Changes are made using QStringLiteral

Dec 21 2017, 5:45 AM · Frameworks

Dec 20 2017

velurimithun updated the diff for D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII ).
  • use QLating1String
Dec 20 2017, 5:08 PM · Frameworks
velurimithun retitled D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII ) from Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII defination) to Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII ).
Dec 20 2017, 3:17 PM · Frameworks