Home
Phabricator
Search
Log In
Differential
D925
Don't change mId from outside
Closed
Public
Actions
Authored by
knauss
on Feb 9 2016, 1:53 PM.
Edit Revision
Update Diff
Download Raw Diff
Edit Related Revisions...
Edit Parent Revisions
Edit Child Revisions
Edit Related Objects...
Edit Commits
Edit Tasks
Subscribe
Mute Notifications
Award Token
Flag For Later
Tags
KDE PIM
Subscribers
kde-pim
Details
Reviewers
mlaurent
Group Reviewers
KDE PIM: KMail
Commits
R43:a3078eb55a97: Don't change mId from outside
R206:00d5619efecd: Don't change mId from outside
Summary
Changeing the mId should only be done inside slotIdentityChanged.
(part of formal
D891
)
Diff Detail
Repository
R43 KDE PIM
Lint
No Linters Available
Unit
No Unit Test Coverage
knauss
updated this revision to
Diff 2249
.
Feb 9 2016, 1:53 PM
knauss
retitled this revision from
to
Don't change mId from outside
.
knauss
updated this object.
knauss
edited the test plan for this revision.
(Show Details)
knauss
added a reviewer:
mlaurent
.
Restricted Application
added a project:
KDE PIM
.
·
View Herald Transcript
Feb 9 2016, 1:53 PM
Restricted Application
added a subscriber:
kde-pim
.
·
View Herald Transcript
knauss
added a reviewer:
KDE PIM: KMail
.
Feb 9 2016, 1:56 PM
mlaurent
accepted this revision.
Feb 10 2016, 5:45 AM
mlaurent
edited edge metadata.
This revision is now accepted and ready to land.
Feb 10 2016, 5:45 AM
Closed by commit
R43:a3078eb55a97: Don't change mId from outside
(authored by
knauss
).
·
Explain Why
Feb 10 2016, 1:55 PM
This revision was automatically updated to reflect the committed changes.