openconnect: patch which add support for seperate pin value for pkcs11 url
plasma-nm openconnect should support separate pin value in config file for pkcs11 url. (Pin should not be visible in log)
Diff Detail
Diff Detail
- Repository
- R116 Plasma Network Management Applet
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
One thing which is not clear to me is where did you get NM_OPENCONNECT_KEY_PIN? All the NM_OPENCONNECT_KEY_* values are synced from NM-openconnect plugin and I don't see anything like that in that NM plugin. We also don't set anything like that in the editor, which means that condition where you check for dataMap[NM_OPENCONNECT_KEY_PIN] will never be true.
Comment Actions
In have no idea about a sync from NM-openconnect plugin. Most code of NM-openconnect plugin is no longer in use. I my opinion it was for forking a openconnect command line process. Looks like most parts of NM-openconnect plugin are obsolete because of libopenconnect usage. And the used code does not handle dataMap in a filter way.
The pin in loaded like any other value in group 'vpn' and just paste into dataMap. I face not such a problem you are describing.
This code is already working right in a "proof of concept (with a softhsm2)" for "City of Munic government" enterprise environment.
| plasma-nm-5.10.5/vpn/openconnect/openconnectauth.cpp | ||
|---|---|---|
| 162 | Coding style. Missing space before "{". | |
| 165 | Coding style. Missing space before "{". | |
| 167 | Coding style. Missing space before "{". | |
| 168 | Coding style. Missing indent. | |
| 203 | Coding style. Missing space before "{". | |
| 397 | Coding style. No space after "if (" and also the whole condition can be on one line, it's not that long. | |
| 398 | Coding style. Missing space before "{". | |
| 400 | Coding style. Missing space before and after "=". | |
Comment Actions
Hi,
i've done a arc redo because of "arc patch" not working and web "diff update" also not working.
D8134 is the updated patch with the requested coding style.
Sorry for not using arc in first place.