Some refactoring in the Shareplugin:
Extracted some parts into separate methods
Extracted notification into separate class
Some optical tweaks on notifications
Details
Details
- Reviewers
albertvaka - Group Reviewers
KDE Connect - Commits
- R225:45f3311b70ba: SharePlugin refactoring
Diff Detail
Diff Detail
- Repository
- R225 KDE Connect - Android application
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
Looks much better! Ship it!
| src/org/kde/kdeconnect/Plugins/SharePlugin/SharePlugin.java | ||
|---|---|---|
| 258 | It seems that the successful variable is not needed, you can pass false to setFinished when called from within the 'catch' block. | |