Disable freehand stroke timeout when airbrushing
ClosedPublic

Authored by allenmarshall on Jul 1 2017, 4:37 PM.

Details

Summary

This revision disables the freehand stroke timeout used by Basic and Weighted smoothing when airbrushing is enabled. This allows airbrushing with a low rate to work with Basic smoothing.

Test Plan

The difference in behavior can be seen as follows.

  1. Set up a brush with the Airbrush option enabled and the rate set to a low value (e.g. 1).
  2. Select the freehand tool and enable Basic smoothing.
  3. Start a freehand stroke, then hold the cursor still without generating any pointer events (easiest to do with a mouse).
  4. With the patch, the airbrush feature should cause dabs to be painted slowly according to the rate configured in step 1. Without the patch, the airbrushing will not happen, because the airbrush rate is slower than the stroke timeout used by Basic smoothing.

The revision causes no new unit test failures on the author's machine.

Diff Detail

Repository
R37 Krita
Lint
Lint Skipped
Unit
Unit Tests Skipped
allenmarshall created this revision.Jul 1 2017, 4:37 PM
allenmarshall added a project: Krita.

It looks like Arcanist included more changes in the diff than I intended. I have updated the diff manually.

Restricted Application added a subscriber: woltherav. · View Herald TranscriptJul 1 2017, 4:41 PM
rempt accepted this revision.Jul 3 2017, 8:54 AM
This revision is now accepted and ready to land.Jul 3 2017, 8:54 AM
This revision was automatically updated to reflect the committed changes.