Differential D5095

[Kompare] Fix Kompare not remembering settings and latest compared files
ClosedPublic
Actions

Authored by jsalatas on Mar 18 2017, 11:08 AM.

Details

Reviewers
kkofler
Commits
R454:4b292e07f08d: Fix Kompare not remembering settings and latest compared files
Summary

Source and Destination URLs are now saved and loaded again after an application restart.

BUG: 346249

Test Plan

Notice: Currently I have hardcoded the maximum number of remembered URLs (10). Do I need to have a user defined option for this? :\

Diff Detail

Repository
R454 Kompare
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jsalatas created this revision.Mar 18 2017, 11:08 AM
kkofler retitled this revision from [Kompare] Kompare don't remember settings and lastest comparing files to [Kompare] Fix Kompare not remembering settings and latest compared files.Mar 18 2017, 11:51 AM
kkofler edited the summary of this revision. (Show Details)
kkofler edited the test plan for this revision. (Show Details)
kkofler accepted this revision.Mar 18 2017, 11:54 AM

Looks OK to me, I think the hardcoded 10 is not an issue.

This revision is now accepted and ready to land.Mar 18 2017, 11:54 AM
Closed by commit R454:4b292e07f08d: Fix Kompare not remembering settings and latest compared files (authored by jsalatas). · Explain WhyMar 18 2017, 12:31 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkompareurldialog.h (5 lines)
Mkompareurldialog.cpp (18 lines)
Mlibdialogpages/filespage.cpp (6 lines)

Diff 12584

View Options

kompareurldialog.h

Loading...
View Options

kompareurldialog.cpp

Loading...
View Options

libdialogpages/filespage.cpp

Loading...