Changeset View
Changeset View
Standalone View
Standalone View
src/gui/openurljob.h
Show First 20 Lines • Show All 104 Lines • ▼ Show 20 Line(s) | 48 | public: | |||
---|---|---|---|---|---|
105 | /** | 105 | /** | ||
106 | * Sets whether the job should follow URL redirections. | 106 | * Sets whether the job should follow URL redirections. | ||
107 | * This is enabled by default. | 107 | * This is enabled by default. | ||
108 | * @param b whether to follow redirections or not. | 108 | * @param b whether to follow redirections or not. | ||
109 | */ | 109 | */ | ||
110 | void setFollowRedirections(bool b); | 110 | void setFollowRedirections(bool b); | ||
111 | 111 | | |||
112 | /** | 112 | /** | ||
113 | * Sets whether the job should right away show the "open with" dialog, | ||||
114 | * without checking for executables, or for associated applications. | ||||
115 | * | ||||
116 | * Compared to using KOpenWithDialog directly, this takes care of determining | ||||
117 | * the mimetype first (if not passed to the constructor), and it allows for | ||||
118 | * a different implementation on Windows. | ||||
119 | * | ||||
kossebau: Please mention explicit what the default is (false), to remove any ambiguity.
Some other… | |||||
120 | * @param b whether to only show the "open with" dialog. | ||||
It seems that we shouldn't end @param with a ".", according to @kossebau anyway... ahmadsamir: It seems that we shouldn't end @param with a ".", according to @kossebau anyway... | |||||
You meant, according to https://community.kde.org/Frameworks/Frameworks_Documentation_Policy#Document_Public_and_Protected_Members :) kossebau: You meant, according to https://community.kde. | |||||
I got the info from a commit in kwidgetsaddons where you "fixed" a previous commit of mine :) Thanks for the link though. ahmadsamir: I got the info from a commit in kwidgetsaddons where you "fixed" a previous commit of mine :)… | |||||
121 | */ | ||||
122 | void setShowOpenWithDialog(bool b); | ||||
123 | | ||||
124 | /** | ||||
113 | * Starts the job. | 125 | * Starts the job. | ||
114 | * You must call this, after having called all the needed setters. | 126 | * You must call this, after having called all the needed setters. | ||
115 | * This is a GUI job, never use exec(), it would block user interaction. | 127 | * This is a GUI job, never use exec(), it would block user interaction. | ||
116 | */ | 128 | */ | ||
117 | void start() override; | 129 | void start() override; | ||
118 | 130 | | |||
119 | Q_SIGNALS: | 131 | Q_SIGNALS: | ||
120 | /** | 132 | /** | ||
Show All 20 Lines |
Please mention explicit what the default is (false), to remove any ambiguity.
Some other setters might want to have this stated as well, btw.