Differential D19194 Diff 53810 applets/digital-clock/package/contents/ui/DigitalClock.qml

Changeset View

Standalone View

View Options

applets/digital-clock/package/contents/ui/DigitalClock.qml

Show First 20 Lines • Show All 296 Lines • ▼ Show 20 Line(s)290 PropertyChanges {
297 minimumPixelSize: dateLabel.minimumPixelSize 297​ minimumPixelSize: dateLabel.minimumPixelSize
298 elide: Text.ElideRight 298​ elide: Text.ElideRight
299 } 299​ }
300 300​
301 PropertyChanges { 301​ PropertyChanges {
302 target: dateLabel 302​ target: dateLabel
303 303​
304 // this can be marginal bigger than contentHeight because of the horizontal fit 304​ // this can be marginal bigger than contentHeight because of the horizontal fit
305 height: Math.max(0.8 * timeLabel.height, minimumPixelSize) 305​ height: sizehelper.contentHeight
anthonyfieroniUnsubmitted
Not Done

You should check if panel orientation, now it's broken horizontal view?

anthonyfieroni: You should check if panel orientation, now it's broken horizontal view?
ZrenUnsubmitted
Not Done

This is inside a State { when: plasmoid.formFactor == PlasmaCore.Types.Vertical }

Zren: This is inside a `State { when: plasmoid.formFactor == PlasmaCore.Types.Vertical }`
cfeckUnsubmitted
Not Done

Could you please clarify? Are changes needed?

cfeck: Could you please clarify? Are changes needed?
ngrahamUnsubmitted
Not Done

No changes are needed; that comment was indicating why @anthonyfieroni's comment was not applicable.

ngraham: No changes are needed; that comment was indicating why @anthonyfieroni's comment was not…
306 width: main.width 306​ width: main.width
307 307​
308 fontSizeMode: Text.Fit 308​ fontSizeMode: Text.Fit
309 minimumPixelSize: Math.min(0.7 * theme.smallestFont.pixelSize, timeLabel.height) 309​ minimumPixelSize: Math.min(0.7 * theme.smallestFont.pixelSize, timeLabel.height)
310 elide: Text.ElideRight 310​ elide: Text.ElideRight
311 } 311​ }
312 312​
313 AnchorChanges { 313​ AnchorChanges {
▲ Show 20 Lines • Show All 386 Lines • Show Last 20 Lines