Differential D13243 Diff 35273 applet/contents/ui/ConfigGeneral.qml

Changeset View

Standalone View

View Options

applet/contents/ui/ConfigGeneral.qml

Show All 23 Lines
24 24​
25import org.kde.plasma.private.volume 0.1 25​import org.kde.plasma.private.volume 0.1
26 26​
27Item { 27​Item {
28 property alias cfg_maximumVolume: maximumVolume.value 28​ property alias cfg_maximumVolume: maximumVolume.value
29 property alias cfg_volumeStep: volumeStep.value 29​ property alias cfg_volumeStep: volumeStep.value
30 property alias cfg_volumeFeedback: volumeFeedback.checked 30​ property alias cfg_volumeFeedback: volumeFeedback.checked
31 property alias cfg_outputChangeOsd: outputChangeOsd.checked 31​ property alias cfg_outputChangeOsd: outputChangeOsd.checked
32​ property alias cfg_showRealDevicesOnly: showRealDevicesOnly.checked
32 33​
33 ColumnLayout { 34​ ColumnLayout {
34 Layout.fillWidth: true 35​ Layout.fillWidth: true
35 36​
36 GroupBox { 37​ GroupBox {
37 Layout.fillWidth: true 38​ Layout.fillWidth: true
38 flat: true 39​ flat: true
39 title: i18n("Volume") 40​ title: i18n("Volume")
▲ Show 20 Lines • Show All 41 Lines • ▼ Show 20 Line(s)80 CheckBox {
81 text: i18n("Volume feedback") 82​ text: i18n("Volume feedback")
82 enabled: feedback.valid 83​ enabled: feedback.valid
83 } 84​ }
84 85​
85 CheckBox { 86​ CheckBox {
86 id: outputChangeOsd 87​ id: outputChangeOsd
87 text: i18n("Visual feedback when default output device changes") 88​ text: i18n("Visual feedback when default output device changes")
88 } 89​ }
90​
91​ CheckBox {
92​ id: showRealDevicesOnly
93​ text: i18n("Show real audio devices and streams only")
94​ }
89 } 95​ }
90 } 96​ }
91 } 97​ }
92 98​
93 VolumeFeedback { 99​ VolumeFeedback {
94 id: feedback 100​ id: feedback
95 } 101​ }
96} 102​}
ngrahamUnsubmitted
Done

This isn't a feedback-related item so it shouldn't be in the Feedback section. I would do it more like this:

Item {
    Kirigami.FormData.isSection: true
}

QQC2.CheckBox {
    id: showRealDevicesOnly
    Kirigami.FormData.label: i18n("Show:")
    text: i18n("Virtual audio streams and devices")
}
ngraham: This isn't a feedback-related item so it shouldn't be in the Feedback section. I would do it…