Create Task
Maniphest T9600

Improve internal window code
Open, NormalPublic
Actions

Description

T8771 hints at the internal window code being problematic in general. This is an entry/overview task to patches improving the code.

Components:

  • Our KWayland interfaces interact with internal clients.
  • KWin QPA code.
  • ShellClient class

Quick plan:

  • A first step could be to subclass internal windows off of ShellClient to have cleaner separation and a more readable code.

Details

Differential Revisions
D22810: Port QPA away from Wayland

Related Objects

romangg created this task.Sep 3 2018, 11:26 AM
romangg triaged this task as Normal priority.
zzag added a revision: D22810: Port QPA away from Wayland.Sep 12 2019, 11:14 AM
zzag claimed this task.
zzag moved this task from Backlog to Under Review on the KWin board.
romangg added a comment.Oct 21 2019, 8:23 AM

What's the status of this task? It's "under review" but there are no open reviews attached.

zzag moved this task from Under Review to Done on the KWin board.Oct 22 2019, 11:31 AM
romangg added a comment.Oct 22 2019, 11:43 AM

Please also change status accordingly.

zzag added a comment.Oct 22 2019, 11:49 AM

I don't have a strong opinion on this one, however I thought that it's better to keep tasks open when they are moved to "Done" because that way one could have a look at what features were implemented previously, etc.