Create Task
Maniphest T7613

Make the ball go to Tux: Fix layout for vertical mode
Closed, ResolvedPublic
Actions

Description

Fix a few visual issues of this activity in vertical mode.

  1. The text in intro is hidden --> https://pasteboard.co/GLwV3ln.png
  2. The arrow keys are hidden by hands --> https://pasteboard.co/GLwVg3s.png
  3. The title is hidden by cross --> https://pasteboard.co/GLwVpaZ.png
asagtani created this task.Dec 16 2017, 3:16 PM
harrymecwan claimed this task.Jan 9 2018, 2:44 PM
harrymecwan added a subscriber: harrymecwan.

i'd like to work on this.

jjazeix added a subscriber: jjazeix.Jan 9 2018, 4:15 PM

sure, the last point may be the trickier one (as it impacts every activity). Don't hesitate to ask if you have any issue either here, by mail or irc

harrymecwan moved this task from Junior Jobs to WIP on the GCompris: Improvements board.Jan 14 2018, 8:52 PM
harrymecwan moved this task from WIP to Need review on the GCompris: Improvements board.
harrymecwan added a comment.Jan 15 2018, 5:09 AM

i've made a PR on the github mirror repo rather than the original one is that okay ?. It's my first one if anything is wrong do correct me.

jjazeix added a comment.Jan 15 2018, 7:19 AM

Hi,
yes, it's ok, just add the link next time (https://github.com/gcompris/GCompris-qt/pull/209), I'll try to review it as soon as I can.
Thank you :)

harrymecwan closed this task as Resolved.Feb 3 2018, 4:23 PM