Showing brush size in the detailed brush preset list in the brush preset docker
Closed, ResolvedPublic

Description

This small patch shows brush size to the left of brush preset names in the brush preset docker (detailed view), as often is the case in other painting applications. Displayed brush size is rounded to the nearest integer, but this might not be ideal for very small brushes where subpixel size differences do matter.

On Windows it looks like this:

neviril created this task.Oct 31 2017, 9:56 PM
Restricted Application added a subscriber: woltherav. · View Herald TranscriptOct 31 2017, 10:04 PM
neviril edited projects, added Krita: Abyss; removed Krita.Oct 31 2017, 10:13 PM

Practical usage considerations: if the "Temporarily save tweaks to presets" option is disabled, the displayed brush size for that preset will remain the last selected one until the preset is selected again; only then it will revert to the original size. Is this a desirable behavior? While at first it appears to contradict the "dirty preset" status/icon, it's consistent with the actual program behavior: if "Temporarily save..." is enabled after the size of a brush preset is changed and after selecting a new brush, but before selecting the previous brush again, the old size will appear to have been preserved. This means that brush size is reset only upon re-selecting the preset. The same occurs even after altering several brush presets.

scottpetrovic added a subscriber: scottpetrovic.EditedOct 31 2017, 11:48 PM

For code reviews there is actually a special section that you can use to submit them. Go back to your home area and one of the sections should be called code review. You can upload your diff from there. Tasks are usually more for things that need discussion with other people. It is just one of those things.

You can assign the reviewer to just 'krita'

scottpetrovic closed this task as Resolved.Nov 1 2017, 1:38 PM
scottpetrovic claimed this task.

the diff was accepted and pushed to master. closing this task