Create Task
Maniphest T1877

Batch extraction of header-encrypted archives: password asked twice if wrong
Closed, ResolvedPublic
Actions

Description

Header-encrypted archives: when batch-extracting them, the password is asked twice if the first time is wrong.

Related Objects

elvisangelaccio added a comment.Mar 22 2016, 6:05 PM

PasswordProtectedHint is ignored e.g. with drag-and-drop extractions, because $PasswordSwitch arg is overwritten by the path of the file and thus is never processed.

This is now fixed with e01cfb4

elvisangelaccio added a comment.Mar 23 2016, 2:50 PM

Extraction to a folder with not enough space: "Extraction failed due to a wrong password."

Fixed with commit e925286.

elvisangelaccio added a comment.Mar 23 2016, 4:21 PM
  • Extraction of password-protected files: if the password is wrong, the temp dir does not autodelete itself.
  • Extraction to a folder with not enough space: ... and again the temp dir does not autodelete.

Fixed with commit 91c316d.

elvisangelaccio lowered the priority of this task from High to Normal.Mar 23 2016, 4:23 PM
elvisangelaccio updated the task description. (Show Details)
elvisangelaccio moved this task from In progress to Backlog on the Ark board.Apr 12 2016, 5:49 PM
elvisangelaccio closed this task as Resolved.Jul 24 2016, 9:33 PM

Header-encrypted archives: when batch-extracting them, the password is asked twice if the first time is wrong.

I can't reproduce this anymore on 16.08 \o/

elvisangelaccio added a comment.Jul 24 2016, 9:36 PM
In T1877#46206, @elvisangelaccio wrote:

Header-encrypted archives: when batch-extracting them, the password is asked twice if the first time is wrong.

I can't reproduce this anymore on 16.08 \o/

...because I was using clirar :/

cliunarchive is actually crashing with header-encrypted archives on 16.08...

elvisangelaccio reopened this task as Open.Jul 25 2016, 5:41 PM

Re-opening: this now affects also cli7z

elvisangelaccio renamed this task from Polish cliunarchiverplugin to Batch extraction of header-encrypted archives: password asked twice if wrong.Jul 25 2016, 5:42 PM
elvisangelaccio raised the priority of this task from Normal to Needs Triage.
elvisangelaccio added a comment.Jul 25 2016, 9:49 PM

I think I found out the reason: this is yet another bug caused by the "hidden" ListJob that we run when we create an archive (see T3300).

If the user enters a wrong password, the ListJob fails but BatchExtract has no way to realize that. It doesn't know that there is a ListJob running in the first place, and it just starts an ExtractJob because that's what it does.

In the cli7z case, the ExtractJob founds again the password prompt line and shows again the PasswordQuery.

elvisangelaccio moved this task from Backlog to Under review on the Ark board.Oct 2 2016, 2:16 PM
elvisangelaccio added a comment.Oct 4 2016, 5:13 PM

Just tested again and now the second prompt is gone. Still, we get no error dialog, but now should be easy to add.

elvisangelaccio moved this task from Under review to In progress on the Ark board.Oct 4 2016, 5:13 PM
elvisangelaccio moved this task from In progress to Done on the Ark board.Oct 5 2016, 9:22 AM
elvisangelaccio closed this task as Resolved.Oct 20 2016, 4:39 PM