Diffusion Calligra f56a9458000a

fromLatin)
f56a9458000a
Actions

Authored by Friedrich W. H. Kossebau <kossebau@kde.org>.

Description

Remove usage of toAscii/fromAscii (basically replace with toLatin/fromLatin)

also:

use implicit conversion from toLatin1-QByteArray to const char*, where possible
constData() instead of data() everywhere, to avoid unneeded deep copies if code get copied
removed unneeded conversion to latin1 where QString was expected
use QByteArray instead of QString, if QString not really needed
cache result of conversion where useful

REVIEW: 107871

Thanks boud and jarosław for review

Details

Committed

Friedrich W. H. Kossebau <kossebau@kde.org>

Dec 28 2012, 10:22 PM

Parents

R8:a23f73c45570: Compile with dbus disabled.

Branches

Unknown

Tags

Unknown

Friedrich W. H. Kossebau <kossebau@kde.org> committed R8:f56a9458000a: Remove usage of toAscii/fromAscii (basically replace with toLatin/fromLatin) (authored by Friedrich W. H. Kossebau <kossebau@kde.org>).Dec 28 2012, 10:22 PM

staniek mentioned this in R15:6b8437490a73: Remove usage of toAscii/fromAscii (replace with toLatin/fromLatin).Jun 4 2015, 10:26 PM

Changes (99)

				Path	Packages
	M			filters/karbon/image/ImageExport.cpp
	M			filters/karbon/pdf/SvgOutputDev.cpp
	M			filters/sheets/excel/sidewinder/XlsRecordOutputStream.cpp
	M			filters/sheets/excel/sidewinder/formulas.cpp
	M			filters/sheets/excel/sidewinder/recordsxml2cpp.cpp
	M			filters/sheets/excel/sidewinder/utils.cpp
	M			filters/sheets/xlsx/XlsxUtils.h
	M			filters/sheets/xlsx/XlsxXmlChartReader.cpp
	M			filters/sheets/xlsx/XlsxXmlWorksheetReader.cpp
	M			filters/stage/powerpoint/PptToOdp.cpp
	M			filters/words/mobi/PalmDocCompression.cpp
	M			filters/words/rtf/import/rtf-qt/src/PictDestination.cpp
	M			kexi/formeditor/commands.cpp
	M			kexi/formeditor/formIO.cpp
	M			kexi/formeditor/utils.cpp
	M			kexi/kexidb/drivers/odbc/odbcdriver.cpp
	M			kexi/kexidb/drivers/odbc/odbcspecialcolumnsqueryunit.cpp
	M			kexi/kexidb/drivers/odbc/odbctablesqueryunit.cpp
	M			kexi/kexidb/drivers/pqxx/pqxxdriver.cpp
	M			kexi/kexidb/drivers/sybase/sybaseconnection.cpp
	M			kexi/kexidb/drivers/xbase/xbaseexport.cpp
	M			kexi/tests/newapi/parser_test.h
	M			krita/image/kis_count_visitor.cpp
	M			krita/image/kis_node.cpp
	M			krita/image/tests/kis_action_recorder_test.cpp
	M			krita/image/tests/kis_convolution_painter_test.cpp
	M			krita/image/tests/kis_cs_conversion_test.cpp
	M			krita/image/tests/kis_filter_job_test.cpp
	M			krita/image/tests/kis_filter_mask_test.cpp
	M			krita/image/tests/kis_filter_test.cpp
	M			krita/image/tests/kis_fixed_paint_device_test.cpp
	M			krita/image/tests/kis_paint_device_test.cpp
	M			krita/image/tests/kis_paint_layer_test.cpp
	M			krita/image/tests/kis_selection_test.cpp
	M			krita/image/tests/kis_transform_worker_test.cpp
	M			krita/image/tests/kis_transparency_mask_test.cpp
	M			krita/image/tiles3/kis_tiled_data_manager.cc
	M			krita/image/tiles3/swap/kis_tile_compressor_2.cpp
	M			krita/plugins/extensions/dockers/lut/ocio_display_filter.cpp
	M			krita/plugins/extensions/metadataeditor/kis_entry_editor.cc
	M			krita/plugins/extensions/metadataeditor/kis_meta_data_editor.cc
	M			krita/plugins/extensions/shiva/ShivaGeneratorConfigWidget.cpp
	M			krita/plugins/extensions/shiva/shivafilter.cpp
	M			krita/plugins/extensions/shiva/shivafiltersplugin.cpp
	M			krita/plugins/extensions/shiva/shivagenerator.cpp
	M			krita/plugins/extensions/shiva/shivageneratorsplugin.cpp
	M			krita/plugins/filters/colorsfilters/kis_perchannel_filter.cpp
	M			krita/plugins/filters/tests/kis_all_filter_test.cpp
	M			krita/plugins/filters/tests/kis_crash_filter_test.cpp
	M			krita/plugins/formats/exr/exr_converter.cc
	M			krita/plugins/formats/psd/psd_layer_record.cpp
	M			krita/plugins/formats/psd/psd_utils.cpp
	M			krita/plugins/formats/tiff/kis_tiff_converter.cc
	M			krita/plugins/paintops/libbrush/kis_gbr_brush.cpp
	M			krita/plugins/paintops/libbrush/tests/kis_auto_brush_test.cpp
	M			krita/plugins/paintops/libbrush/tests/kis_brush_test.cpp
	M			krita/plugins/paintops/libpaintop/kis_texture_option.cpp
	M			krita/plugins/paintops/mypaint/mypaint_paintop_factory.cpp
	M			krita/ui/kis_clipboard.cc
	M			krita/ui/kis_png_converter.cpp
	M			krita/ui/kis_workspace_resource.cpp
	M			krita/ui/kisexiv2/kis_exif_io.cpp
	M			krita/ui/kisexiv2/kis_exiv2.cpp
	M			krita/ui/kisexiv2/kis_xmp_io.cpp
	M			krita/ui/opengl/kis_opengl_shader.cpp
	M			libs/flake/KoUnavailShape.cpp
	M			libs/kotext/opendocument/KoTextWriter_p.cpp
	M			libs/kotext/styles/KoCharacterStyle.cpp
	M			libs/main/KoDocumentInfo.cpp
	M			libs/main/KoFilterChain.cpp
	M			libs/main/KoMainWindow.cpp
	M			libs/odf/KoEncryptedStore.cpp
	M			libs/odf/KoProperties.cpp
	M			libs/odf/tests/storedroptest.cpp
	M			libs/pigment/resources/KoColorSet.cpp
	M			libs/pigment/resources/KoPattern.cpp
	M			libs/widgets/KoResourceServer.h
	M			libs/widgets/KoResourceServerProvider.cpp
	M			plan/libs/models/kptitemmodelbase.cpp
	M			plan/plugins/schedulers/rcps/KPlatoRCPSScheduler.cpp
	M			plugins/chartshape/CellRegion.cpp
	M			plugins/chartshape/ChartTableModel.cpp
	M			plugins/chartshape/tests/TestDataSet.cpp
	M			plugins/chartshape/tests/TestProxyModel.cpp
	M			plugins/chartshape/tests/odf/TestLoadingBase.cpp
	M			plugins/colorengines/lcms2/IccColorSpaceEngine.cpp
	M			plugins/colorengines/lcms2/colorprofiles/LcmsColorProfileContainer.cpp
	M			plugins/colorengines/lcms2/tests/TestKoColorSpaceRegistry.cpp
	M			plugins/formulashape/Dictionary.cpp
	M			plugins/musicshape/core/MusicXmlReader.cpp
	M			plugins/pathshapes/enhancedpath/EnhancedPathFormula.cpp
	M			plugins/pathshapes/enhancedpath/EnhancedPathShape.cpp
	M			plugins/reporting/barcode/3of9.cpp
	M			plugins/reporting/barcode/3of9paint.cpp
	M			plugins/reporting/barcode/code128.cpp
	M			plugins/reporting/barcode/code128paint.cpp
	M			plugins/reporting/barcode/ext3of9.cpp
	M			plugins/reporting/barcode/ext3of9paint.cpp
	M			sheets/Global.h