Fix random crashes when converting image color space
a9b8a3a1fa2b
Actions

Authored by dkazakov on Sep 11 2019, 12:54 PM.

Description

Fix random crashes when converting image color space

The patch basically ports image color space conversion into strokes
system. The crash happened becasue updates were initiated right when
the visitor was changing layers. With the strokes, this problem should
be resolved.

The patch also changed UIX: now 'Image->Properties->Color Space'
changes the entire color space of the image, but not only color space
of the root node (projection).

BUG:410776

Details

Committed

dkazakov

Sep 11 2019, 5:14 PM

Parents

R37:0381878fcb6c: Fix a crash when loading JPEG image with a weird color profile

Branches

Unknown

Tags

Unknown

dkazakov committed R37:a9b8a3a1fa2b: Fix random crashes when converting image color space (authored by dkazakov).Sep 11 2019, 5:14 PM

Changes (20)

				Path	Packages
	M			libs/image/CMakeLists.txt
	D			libs/image/kis_colorspace_convert_visitor.cpp
	D			libs/image/kis_colorspace_convert_visitor.h
	M			libs/image/kis_image.cc
	M			libs/image/kis_image.h
	M			libs/image/kis_paint_device.cc
	M			libs/image/kis_transform_mask.cpp
	M			libs/image/lazybrush/kis_colorize_mask.cpp
	A			libs/image/processing/kis_convert_color_space_processing_visitor.cpp
	P			libs/image/processing/kis_convert_color_space_processing_visitor.h Copied from libs/image/processing/kis_crop_processing_visitor.h
	M			libs/image/tests/CMakeLists.txt
	D			libs/image/tests/kis_colorspace_convert_visitor_test.cpp
	D			libs/image/tests/kis_colorspace_convert_visitor_test.h
	M			libs/image/tests/kis_image_test.cpp
	M			libs/libkis/Document.cpp
	M			libs/libkis/Node.cpp
	M			libs/ui/kis_image_manager.cc
	M			plugins/extensions/colorspaceconversion/colorspaceconversion.cc
	M			plugins/impex/psd/psd_saver.cpp
	M			sdk/tests/filestest.h

Fix random crashes when converting image color spacea9b8a3a1fa2bActions

Description

Details

Changes (20)

R37:a9b8a3a1fa2b

libs/image/CMakeLists.txt

libs/image/kis_colorspace_convert_visitor.cpp

libs/image/kis_colorspace_convert_visitor.h

libs/image/kis_image.cc

libs/image/kis_image.h

libs/image/kis_paint_device.cc

libs/image/kis_transform_mask.cpp

libs/image/lazybrush/kis_colorize_mask.cpp

libs/image/processing/kis_convert_color_space_processing_visitor.cpp

libs/image/processing/kis_convert_color_space_processing_visitor.h

libs/image/tests/CMakeLists.txt

libs/image/tests/kis_colorspace_convert_visitor_test.cpp

libs/image/tests/kis_colorspace_convert_visitor_test.h

libs/image/tests/kis_image_test.cpp

libs/libkis/Document.cpp

libs/libkis/Node.cpp

libs/ui/kis_image_manager.cc

plugins/extensions/colorspaceconversion/colorspaceconversion.cc

plugins/impex/psd/psd_saver.cpp

sdk/tests/filestest.h

Fix random crashes when converting image color space
a9b8a3a1fa2b
Actions