Wrap the undo commands in a QPointer
68ca0a9afba1
Actions

Authored by rempt on Sep 19 2016, 11:09 AM.

Description

Wrap the undo commands in a QPointer

This should fix the problems when trying to merge already deleted
commands in the timedMergeWith method, because now we can track
whether the QObject-based KUndo2Command instances have been deleted
behind our back.

BUG:366607

Details

Committed

rempt

Sep 19 2016, 11:09 AM

Parents

R37:789d8b648468: Move KUndo2Command into its own file and make it a QObject

Branches

Unknown

Tags

Unknown

Reverted By

R37:60fca35a359d: Revert "Wrap the undo commands in a QPointer"

rempt committed R37:68ca0a9afba1: Wrap the undo commands in a QPointer (authored by rempt).Sep 19 2016, 11:09 AM

rempt added a reverting change: R37:60fca35a359d: Revert "Wrap the undo commands in a QPointer".Sep 19 2016, 12:20 PM

rempt mentioned this in R37:60fca35a359d: Revert "Wrap the undo commands in a QPointer".

Changes (26)

				Path	Packages
	M			libs/image/commands_new/kis_change_projection_color_command.cpp
	M			libs/image/commands_new/kis_change_projection_color_command.h
	M			libs/image/commands_new/kis_saved_commands.cpp
	M			libs/image/commands_new/kis_saved_commands.h
	M			libs/image/commands_new/kis_switch_current_time_command.cpp
	M			libs/image/commands_new/kis_switch_current_time_command.h
	M			libs/kundo2/kundo2command.cpp
	M			libs/kundo2/kundo2command.h
	M			libs/kundo2/kundo2stack.cpp
	M			libs/kundo2/kundo2stack.h
	M			libs/ui/canvas/kis_change_guides_command.cpp
	M			libs/ui/canvas/kis_change_guides_command.h
	M			plugins/flake/textshape/TextTool.cpp
	M			plugins/flake/textshape/commands/ChangeListLevelCommand.cpp
	M			plugins/flake/textshape/commands/ChangeListLevelCommand.h
	M			plugins/flake/textshape/kotext/KoTextCommandBase.h
	M			plugins/flake/textshape/kotext/KoTextEditor_undo.cpp
	M			plugins/flake/textshape/kotext/OdfTextTrackStyles.cpp
	M			plugins/flake/textshape/kotext/commands/ChangeListCommand.cpp
	M			plugins/flake/textshape/kotext/commands/ChangeListCommand.h
	M			plugins/flake/textshape/kotext/commands/DeleteCommand.cpp
	M			plugins/flake/textshape/kotext/commands/DeleteCommand.h
	M			plugins/flake/textshape/kotext/commands/ListItemNumberingCommand.cpp
	M			plugins/flake/textshape/kotext/commands/ListItemNumberingCommand.h
	M			plugins/flake/textshape/kotext/commands/RenameSectionCommand.cpp
	M			plugins/flake/textshape/kotext/commands/RenameSectionCommand.h