Fix memory leaks caused by KisPaintDevice::convertTo()
4bab45a28bac
Actions

Authored by dkazakov on Apr 9 2019, 10:55 AM.

Description

Fix memory leaks caused by KisPaintDevice::convertTo()

For years this method returned KUndoCommand and for years we
forgot to delete this command, causing memory leaks.

This patch refactors convertTo() call to not return anythingon heap,
but just accepting optional parent command.

Committed

dkazakov

Apr 9 2019, 11:22 AM

Parents

R37:214d419c911b: Fix wrong position of the merged layer

Branches

Unknown

Tags

Unknown

				Path	Packages
	M			libs/command/kis_command_utils.cpp
	M			libs/image/kis_colorspace_convert_visitor.cpp
	M			libs/image/kis_paint_device.cc
	M			libs/image/kis_paint_device.h
	M			libs/image/kis_paint_device_data.h
	M			libs/image/kis_pixel_selection.cpp
	M			libs/image/lazybrush/kis_colorize_mask.cpp
	M			libs/image/tests/kis_cs_conversion_test.cpp
	M			libs/image/tests/kis_paint_device_test.cpp
	M			libs/ui/kis_import_catcher.cc
	M			libs/ui/kis_png_converter.cpp
	M			plugins/filters/fastcolortransfer/fastcolortransfer.cpp
	M			plugins/filters/fastcolortransfer/kis_wdg_fastcolortransfer.cpp
	M			plugins/filters/phongbumpmap/kis_phong_bumpmap_filter.cpp
	M			plugins/impex/csv/csv_saver.cpp
	M			plugins/impex/heightmap/kis_heightmap_export.cpp
	M			plugins/impex/jpeg/kis_jpeg_converter.cc
	M			plugins/impex/psd/psd_layer_record.cpp
	M			plugins/impex/spriter/kis_spriter_export.cpp
	M			plugins/paintops/libpaintop/KisDabCacheUtils.cpp