Diffusion Krita 3fb4c3bceba8

Add a TODO item for KoShapeReorderCommand refactoring

Authored by dkazakov on Jan 10 2018, 5:30 PM.

Description

Add a TODO item for KoShapeReorderCommand refactoring

The method doesn't support the case when one of the shapes has
minimum or maximum zIndex value and lets the integer overflow easily.

The overflow can happen quite easily if some (not very nice) code
decides to put the shape into the topmost level by setting its
zIndex to maximum

Details

Committed
dkazakovJan 10 2018, 5:30 PM
Parents
R37:df8f9900b5cf: Fix correct initialization of zIndex for the D&D'ed shapes
Branches
Unknown
Tags
Unknown

As it is true it should not overflow. I think it would also be good to change the zIndex to a int32_t or the equivialent qt type