Refactor the resize canva dialog to use unitparsespinboxes
Concern Raised233d3b73d7d2
Actions

Authored by jospin on Jan 22 2017, 8:57 AM.

Description

Refactor the resize canva dialog to use unitparsespinboxes

The new dialog looks more or less the same, except now it's possible to change the unit with the keyboard (and new units are present, like vh or vw).

For the moment, only the resize canva dialog have been refactored. If you want to test the new design and propose other approaches test with this dialog.

Mayba a good idea would be to have a dedicated widget with the spinbox and the combobox. Then the user can select via the configuration if he/she want the unit to be displayed in the spinbox (and the combobox is hidden) or in the combobox. What do you think ?

Details

Auditors

rempt

Committed

jospin

Jan 22 2017, 8:57 AM

Parents

R37:84b87a952c3b: Make the spinboxunitmanager a QAbstractListModel

Branches

Unknown

Tags

Unknown

Tasks

T1621: Numerical input boxes

jospin added a task: T1621: Numerical input boxes.Jan 22 2017, 9:05 AM

jospin committed R37:233d3b73d7d2: Refactor the resize canva dialog to use unitparsespinboxes (authored by jospin).Jan 22 2017, 8:57 AM

Right now, it's impossible to change the print dimensions properly. The Contrain Proportions icon for print size cannot be clicked.

If I check "Adjust print size separately" and want to edit the Print size Width, the Printt size Height immediately changes to something completely wrong.

This commit now has outstanding concerns.Dec 31 2017, 2:10 PM

Changes (7)

				Path	Packages
	M			libs/widgets/kis_double_parse_unit_spin_box.cpp
	M			libs/widgets/kis_double_parse_unit_spin_box.h
	M			libs/widgetutils/kis_spin_box_unit_manager.cpp
	M			libs/widgetutils/kis_spin_box_unit_manager.h
	M			plugins/extensions/imagesize/dlg_canvassize.cc
	M			plugins/extensions/imagesize/dlg_canvassize.h
	M			plugins/extensions/imagesize/wdg_canvassize.ui