Fix Node often not being properly subtyped
21b38bdafc7d
Actions

Authored by Jimbo Whales <htns@tutanota.de> on Sep 11 2019, 7:07 PM.

Description

Fix Node often not being properly subtyped

Nodes should be created with the added Node::createNode instead of the
Node constructor, which cannot return a subtype of Node even if there
is one for the wrapped KisNode. The constructor is now private.

Details

Committed

Jimbo Whales <htns@tutanota.de>

Sep 12 2019, 2:12 PM

Parents

R37:1b0007d818a0: Fix Document::nodeByName not returning null

Branches

Unknown

Tags

Unknown

Jimbo Whales <htns@tutanota.de> committed R37:21b38bdafc7d: Fix Node often not being properly subtyped (authored by Jimbo Whales <htns@tutanota.de>).Sep 12 2019, 2:12 PM

Changes (7)

				Path	Packages
	M			libs/libkis/Document.cpp
	M			libs/libkis/LibKisUtils.cpp
	M			libs/libkis/Node.cpp
	M			libs/libkis/Node.h
	M			libs/libkis/tests/TestChannel.cpp
	M			libs/libkis/tests/TestFilter.cpp
	M			libs/libkis/tests/TestNode.cpp