Refactor ArchiveEntry to Archive::Entry and move it to Kerfuffle (see…
7d7e49f76516
Actions

Authored by mvlabat on May 28 2016, 3:06 PM.

Description

Refactor ArchiveEntry to Archive::Entry and move it to Kerfuffle (see comments in T2704)

Committed

mvlabat

Jun 7 2016, 9:22 PM

Parents

Branches

Unknown

Tags

Unknown

Some general notes aboute the coding style:

Use Q_NULLPTR instead of NULL
Declare pointers as Foo *bar instead of Foo* bar
Don't put Qt module names in the includes. Use #include <QIcon> instead of #include <QtGui/QIcon>.

/kerfuffle/archiveentry.h
73	Call this one `m_children` ?
/part/archivemodel.cpp
427–441	Please add a `// TODO GSoC` comment here, otherwise we might forget about this

Can you also try to get rid of EntryMetaDataType defined in archive_kerfuffle.h?

				Path	Packages
	M			autotests/kerfuffle/jobstest.cpp
	M			autotests/kerfuffle/jsonarchiveinterface.cpp
	M			autotests/kerfuffle/jsonparser.cpp
	M			autotests/kerfuffle/jsonparser.h
	M			autotests/plugins/cli7zplugin/cli7ztest.cpp
	M			autotests/plugins/cli7zplugin/cli7ztest.h
	M			autotests/plugins/clirarplugin/clirartest.cpp
	M			autotests/plugins/clirarplugin/clirartest.h
	M			autotests/plugins/cliunarchiverplugin/cliunarchivertest.cpp
	M			autotests/plugins/cliunarchiverplugin/cliunarchivertest.h
	M			kerfuffle/CMakeLists.txt
	M			kerfuffle/archive_kerfuffle.cpp
	M			kerfuffle/archive_kerfuffle.h
	A			kerfuffle/archiveentry.cpp
	A			kerfuffle/archiveentry.h
	M			kerfuffle/archiveinterface.h
	M			kerfuffle/jobs.cpp
	M			kerfuffle/jobs.h
	M			part/archivemodel.cpp
	M			part/archivemodel.h
	M			part/infopanel.cpp
	M			part/part.cpp
	M			plugins/cli7zplugin/cliplugin.cpp
	M			plugins/cli7zplugin/cliplugin.h
	M			plugins/cliplugin-example/cliplugin.cpp
	M			plugins/cliplugin-example/cliplugin.h
	M			plugins/clirarplugin/cliplugin.cpp
	M			plugins/cliunarchiverplugin/cliplugin.cpp
	M			plugins/cliunarchiverplugin/cliplugin.h
	M			plugins/clizipplugin/cliplugin.cpp
	M			plugins/libarchive/libarchiveplugin.cpp
	M			plugins/libsinglefileplugin/singlefileplugin.cpp